Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1726: Add image for smb-csi-driver-operator #50848

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jsafrane
Copy link
Contributor

It will be available via OLM. e2e tests will follow.

@openshift/storage

It will be available via OLM. e2e tests will follow.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2024

@jsafrane: This pull request references STOR-1726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

It will be available via OLM. e2e tests will follow.

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jsafrane: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-aws-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-aws-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-file-nfs-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-manual-oidc openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azure-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-e2e-azurestack-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-hypershift-aws-e2e-external openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-images openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-security openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-unit openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-verify openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.17-verify-deps openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-aws-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-release-4.16-e2e-azure-file-csi openshift/csi-operator presubmit Ci-operator config changed

A total of 54 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jsafrane
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-csi-operator-release-4.16-images pull-ci-openshift-csi-operator-release-4.17-images

@openshift-ci-robot
Copy link
Contributor

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@jsafrane
Copy link
Contributor Author

/pj-rehearse ack

4.17 image builds, just the 4.17 release image appears to be broken.

@openshift-ci-robot
Copy link
Contributor

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 12, 2024
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/csi-operator/release-4.17/images c4f6b2a link unknown /pj-rehearse pull-ci-openshift-csi-operator-release-4.17-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e7ca35b into openshift:master Apr 12, 2024
16 of 17 checks passed
saifshaikh48 pushed a commit to saifshaikh48/release that referenced this pull request Apr 23, 2024
It will be available via OLM. e2e tests will follow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants