Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add managed cluster to framework tests #51057

Merged
merged 5 commits into from May 23, 2024

Conversation

dhaiducek
Copy link
Contributor

@dhaiducek dhaiducek commented Apr 17, 2024

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@dhaiducek dhaiducek force-pushed the framework-managed branch 3 times, most recently from 6c38f9a to 2492dd1 Compare April 17, 2024 21:47
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

@mprahl mprahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold in case you want other reviews

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@@ -159,4 +158,4 @@ presubmits:
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )test-e2e-grc-framework,?($|\s.*)
trigger: (?m)^/test( | .* )(test-e2e-grc-framework|remaining-required),?($|\s.*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the remaining-required for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a "secondary" job intended to be triggered manually, it can be triggered with /test remaining-required (which would also apply to other secondary jobs if we had any).

ref: https://docs.ci.openshift.org/docs/how-tos/creating-a-pipeline/#manual-pipelines

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dhaiducek
Copy link
Contributor Author

This PR is currently blocked, waiting on removal of IamPolicy from the klusterlet-addon-controller:

The KlusterletAddonConfig "managed-1" is invalid: spec.iamPolicyController: Required value

https://github.com/stolostron/klusterlet-addon-controller

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

3 similar comments
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Establishes a common `checkoutCluster()` function.

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dhaiducek: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicloud-integrations-main-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.8-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.11-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.4-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.5-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.6-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.10-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.7-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-release-2.9-pr-image-mirror stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-multicloud-integrations-main-ocm-ci-rbac stolostron/multicloud-integrations presubmit Registry content changed
pull-ci-stolostron-observatorium-main-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-observatorium-release-2.10-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-observatorium-release-2.11-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-observatorium-release-2.9-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-observatorium-release-2.8-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-observatorium-release-2.6-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-observatorium-release-2.7-pr-image-mirror stolostron/observatorium presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-main-pr-image-mirror stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-release-2.9-pr-image-mirror stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-release-2.7-pr-image-mirror stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-release-2.10-pr-image-mirror stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-release-2.8-pr-image-mirror stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-release-2.11-pr-image-mirror stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-multicloud-operators-application-main-ocm-ci-rbac stolostron/multicloud-operators-application presubmit Registry content changed
pull-ci-stolostron-application-ui-main-pr-image-mirror stolostron/application-ui presubmit Registry content changed

A total of 593 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dhaiducek
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@dhaiducek
Copy link
Contributor Author

dhaiducek commented May 23, 2024

@openshift-ci-robot
Copy link
Contributor

@dhaiducek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 23, 2024
@JustinKuli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, gurnben, JustinKuli, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 23, 2024

@dhaiducek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/governance-policy-framework/main/test-e2e-grc-framework 4a95c19 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-main-test-e2e-grc-framework

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 754360e into openshift:master May 23, 2024
22 of 23 checks passed
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@dhaiducek: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-stolostron-governance-policy-framework-_prowconfig.yaml using file core-services/prow/02_config/stolostron/governance-policy-framework/_prowconfig.yaml

In response to this:

ref: https://issues.redhat.com/browse/ACM-11162

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants