Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile path in oc tools image #51253

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Apr 23, 2024

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@soltysh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oc-master-build-rpms-from-tar openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-agnostic-ovn-cmd openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-aws-certrotation openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-aws-ovn openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-aws-ovn-builds openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-aws-ovn-serial openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-aws-ovn-upgrade openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-images openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-rpm-build openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-security openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-unit openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-verify openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-master-verify-deps openshift/oc presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@soltysh
Copy link
Member Author

soltysh commented Apr 23, 2024

/pj-rehearse pull-ci-openshift-oc-master-images

@openshift-ci-robot
Copy link
Contributor

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member

It seems that bot aligned with the changes in tools by converting the base image to base-rhel9 but couldn't incorporate the fix in here.

Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@soltysh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Member Author

soltysh commented Apr 23, 2024

This worked as expected, no need to test more.
/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@soltysh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 666d68f into openshift:master Apr 23, 2024
16 checks passed
@soltysh soltysh deleted the fix_path branch April 23, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants