Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPQE-21220: [4.16] move more ci jobs to multi arch ci #51338

Merged
merged 1 commit into from Apr 26, 2024

Conversation

jianlinliu
Copy link
Contributor

@jianlinliu jianlinliu commented Apr 25, 2024

  1. per our agreement on multi-arch payload coverage, if the job can be run in multi-arch ci, then multi arch ci has the priority, so move more gcp/aws/azure ci jobs to there.
  2. remove some duplicated ci jobs, e.g:
    azure-ipi-disk-encryption-set is already covered by azure-ipi-des-minimal-permission-amd-mixarch
    azure-ipi-ovn-ipsec is already covered by azure-ipi-ovn-ipsec-arm-mixarch
  3. rename minimal-permission to mini-perm for a shorter job name and keep consistent across all platforms.
  4. decrease ipi-ovn-ipsec-arm-mixarch test frequency a bit, because more ci jobs are added in multi-arch ci.

@jianlinliu jianlinliu changed the title [4.16] move arm ci jobs to multi arch ci [4.16] move more ci jobs to multi arch ci Apr 25, 2024
@jianlinliu
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-upi-arm-f28 periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-ipi-oidc-rt-fips-amd-f14

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jianlinliu
Copy link
Contributor Author

@yunjiang29 @jinyunma @jianli-wei pls help review, also cc @JianLi-RH to be noticed.

@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 26, 2024
@jinyunma
Copy link
Contributor

azure-ipi-disk-encryption-set is already covered by azure-ipi-des-minimal-permission-amd-mixarch

seems that profile azure-ipi-des-minimal-permission-amd-mixarch is only in upgrade ci job, and profile azure-ipi-disk-encryption-set is removed from openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml, didn't find either of them in openshift-openshift-tests-private-release-4.16__multi-nightly.yaml, but both are in 4.16 upgrade ci job, is it on purpose?

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Apr 26, 2024

azure-ipi-disk-encryption-set is already covered by azure-ipi-des-minimal-permission-amd-mixarch

seems that profile azure-ipi-des-minimal-permission-amd-mixarch is only in upgrade ci job, and profile azure-ipi-disk-encryption-set is removed from openshift-openshift-tests-private-release-4.16__amd64-nightly.yaml, didn't find either of them in openshift-openshift-tests-private-release-4.16__multi-nightly.yaml, but both are in 4.16 upgrade ci job, is it on purpose?

Maybe I can update azure-ipi-des-fips-amd-f28 in openshift-openshift-tests-private-release-4.16__multi-nightly-4.16-upgrade-from-stable-4.15.yaml (and another z-stream upgrade ci) to azure-ipi-des-mini-perm-fips-amd-f28 to keep consistent, the reason of not removing the one in upgrade ci is because we are combining fips on the install profile, wdyt?

@jinyunma
Copy link
Contributor

Maybe I can update azure-ipi-des-fips-amd-f28 in openshift-openshift-tests-private-release-4.16__multi-nightly-4.16-upgrade-from-stable-4.15.yaml (and another z-stream upgrade ci) to azure-ipi-des-mini-perm-fips-amd-f28 to keep consistent, the reason of not removing the one in upgrade ci is because we are combining fips on the install profile, wdyt?

I'm okay for the change in upgrade CI.
But my concern is that if so, only one profile azure-des-min-perm is in 4.16 e2e CI, which configures DES by setting ENABLE_DES_COMPUTE and ENABLE_DES_CONTROL_PLANE. And another scenario to configure DES via ENABLE_DES_DEFAULT_MACHINE is missing in e2e CI, and I think this has high priority to test because default sc will also configure des for data disk encryption. so maybe we also need to add profile (via ENABLE_DES_DEFAULT_MACHINE) into 4.16 e2e CI ?

@jianlinliu
Copy link
Contributor Author

jianlinliu commented Apr 26, 2024

And another scenario to configure DES via ENABLE_DES_DEFAULT_MACHINE is missing in e2e CI, and I think this has high priority to test because default sc will also configure des for data disk encryption

Good point, for now, I am seeing azure-ipi-des-mini-perm-fips in e2e CI to cover ENABLE_DES_COMPUTE and ENABLE_DES_CONTROL_PLANE, and the destructive e2e job is covering ENABLE_DES_DEFAULT_MACHINE, is that okay? or you want to switch over to use non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE` ?

@jinyunma
Copy link
Contributor

jinyunma commented Apr 26, 2024

or you want to switch over to use non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE` ?

Checked with @Phaow , their BYOK cases are all non-destructive, so better to use non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE.

Edit: seems that current job is as expected, using non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE, no need to change any more. @jianlinliu thanks for checking, didn't notice this before.

@jianlinliu
Copy link
Contributor Author

or you want to switch over to use non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE` ?

Checked with @Phaow , their BYOK cases are all non-destructive, so better to use non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE.

Edit: seems that current job is as expected, using non-destructive job to cover ENABLE_DES_DEFAULT_MACHINE, no need to change any more. @jianlinliu thanks for checking, didn't notice this before.

Right, my last message confused you, the current jobs are there as our expectation.

@jinyunma
Copy link
Contributor

LGTM for azure part

@jianlinliu
Copy link
Contributor Author

Maybe I can update azure-ipi-des-fips-amd-f28 in openshift-openshift-tests-private-release-4.16__multi-nightly-4.16-upgrade-from-stable-4.15.yaml (and another z-stream upgrade ci) to azure-ipi-des-mini-perm-fips-amd-f28 to keep consistent

Done

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianlinliu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-azure-ipi-des-mini-perm-fips-amd-f9-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-upi-arm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-aws-ipi-usertags-custom-sg-fips-amd-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-sno-lvms-arm-f2 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-stable-4.16-upgrade-from-stable-4.16-azure-ipi-des-mini-perm-amd-mixarch-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-azure-ipi-ultrassd-disks-fips-amd-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-azure-ipi-des-mini-perm-fips-amd-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-azure-upi-mini-perm-amd-f9-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.16-nutanix-ipi-proxy-fips-mini-perm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-azure-upi-mini-perm-arm-f2 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-azure-ipi-des-day2-fips-amd-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-azure-ipi-ingress-custom-controller-fips-amd-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.16-azure-ipi-des-mini-perm-fips-amd-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.16-aws-ipi-ovn-ipsec-arm-mixarch-day2-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-registry-s3-cloudfront-arm-f5 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-azure-ipi-ovn-ipsec-arm-mixarch-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-ibmcloud-ipi-mini-perm-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-aws-ipi-mini-perm-amd-f14-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-stable-4.16-upgrade-from-stable-4.16-nutanix-ipi-proxy-fips-mini-perm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-nutanix-ipi-proxy-fips-mini-perm-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-xpn-mini-perm-arm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-azure-ipi-fullyprivate-proxy-arm-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-azure-ipi-marketplace-mini-perm-f5 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-gcp-ipi-mini-perm-custom-type-f28 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-xpn-mini-perm-fips-amd-f28-destructive N/A periodic Periodic changed

A total of 49 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 26, 2024
@jianlinliu
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@jianlinliu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-ipi-oidc-rt-fips-amd-f14 e857ea9 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-ipi-oidc-rt-fips-amd-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-upi-arm-f28 e857ea9 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-gcp-upi-arm-f28

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jinyunma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@jianlinliu
Copy link
Contributor Author

cc @liangxia to review.

@liangxia
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@jianlinliu jianlinliu changed the title [4.16] move more ci jobs to multi arch ci OCPQE-21220: [4.16] move more ci jobs to multi arch ci Apr 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2024

@jianlinliu: This pull request references OCPQE-21220 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

  1. per our agreement on multi-arch payload coverage, if the job can be run in multi-arch ci, then multi arch ci has the priority, so move more gcp/aws/azure ci jobs to there.
  2. remove some duplicated ci jobs, e.g:
    azure-ipi-disk-encryption-set is already covered by azure-ipi-des-minimal-permission-amd-mixarch
    azure-ipi-ovn-ipsec is already covered by azure-ipi-ovn-ipsec-arm-mixarch
  3. rename minimal-permission to mini-perm for a shorter job name and keep consistent across all platforms.
  4. decrease ipi-ovn-ipsec-arm-mixarch test frequency a bit, because more ci jobs are added in multi-arch ci.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianli-wei
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, jianlinliu, jinyunma, liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f6002a7 into openshift:master Apr 26, 2024
17 checks passed
@yunjiang29
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants