Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33091: Only place the VM storage pools on small second disks #51453

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

derekhiggins
Copy link
Contributor

If the disk on a virt hosts are less then 200G then it
can't store both the VM storage pools and the image
registry.

Also
Test access to API during devscripts-gather

devscripts gather has access to the API without going
through the proxy.

devscripts gather has access to the API without going
through the proxy.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@derekhiggins
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

If the disk on a virt hosts are less then 200G then it
can't store both the VM storage pools and the image
registry.
@derekhiggins
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-upgrade-ovn-ipv6 periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@derekhiggins: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-metallb-main-metallb-e2e-metal-frrk8s openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-main-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.17-metallb-e2e-metal-frrk8s openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.17-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.16-metallb-e2e-metal-frrk8s openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.16-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.15-metallb-e2e-metal-ipi openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.15-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.14-metallb-e2e-metal-ipi openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.14-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.13-metallb-e2e-metal-ipi openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.13-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.12-metallb-e2e-metal-ipi openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.12-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.11-metallb-e2e-metal-ipi openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.11-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.10-metallb-e2e-metal-ipi openshift/metallb presubmit Registry content changed
pull-ci-openshift-metallb-release-4.10-metallb-e2e-metal-ipi-ovn openshift/metallb presubmit Registry content changed
pull-ci-openshift-oc-master-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed
pull-ci-openshift-oc-release-4.17-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed
pull-ci-openshift-oc-release-4.16-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed
pull-ci-openshift-oc-release-4.15-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed
pull-ci-openshift-oc-release-4.14-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed
pull-ci-openshift-oc-release-4.13-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed
pull-ci-openshift-oc-release-4.12-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Registry content changed

A total of 1719 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@stbenjam
Copy link
Member

/retitle OCPBUGS-33091: Only place the VM storage pools on small second disks

@openshift-ci openshift-ci bot changed the title Only place the VM storage pools on small second disks OCPBUGS-33091: Only place the VM storage pools on small second disks Apr 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link
Contributor

@derekhiggins: This pull request references Jira Issue OCPBUGS-33091, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

If the disk on a virt hosts are less then 200G then it
can't store both the VM storage pools and the image
registry.

Also
Test access to API during devscripts-gather

devscripts gather has access to the API without going
through the proxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 29, 2024
@stbenjam
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 29, 2024
@openshift-ci-robot
Copy link
Contributor

@stbenjam: This pull request references Jira Issue OCPBUGS-33091, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 29, 2024
@openshift-ci openshift-ci bot requested a review from jadhaj April 29, 2024 12:03
@derekhiggins
Copy link
Contributor Author

The upgrade jobs didn't run on ESI, but the PR had the desired effect of only putting the VM pools on the second disk(taken from the ipv6 job)

$ df -h / /opt/dev-scripts/pool
Filesystem      Size  Used Avail Use% Mounted on
/dev/sda2       175G   35G  133G  21% /
/dev/sdb        187G  103G   84G  55% /opt/dev-scripts/pool

@derekhiggins
Copy link
Contributor Author

/pj-rehearse ack
the upgrade job still running is currently broken
I'm not sure even with this the disk will be large enough but if we merge it we should find out fairly quickly

@openshift-ci-robot
Copy link
Contributor

@derekhiggins: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 29, 2024
@tdomnesc
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, tdomnesc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6 9db317f link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-upgrade-ovn-ipv6 9db317f link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-upgrade-ovn-ipv6
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6 9db317f link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.16-upgrade-from-stable-4.15-e2e-metal-ipi-upgrade-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 57f248f into openshift:master Apr 29, 2024
14 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@derekhiggins: Jira Issue OCPBUGS-33091: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33091 has been moved to the MODIFIED state.

In response to this:

If the disk on a virt hosts are less then 200G then it
can't store both the VM storage pools and the image
registry.

Also
Test access to API during devscripts-gather

devscripts gather has access to the API without going
through the proxy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants