OSASINFRA-3435: openstack: Add CAPI-installer periodics #51618
Conversation
openshift-ci
bot
added
the
approved
|
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ovn-password |
|
@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
pierreprinetti
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@pierreprinetti: This pull request references OSASINFRA-3435 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| ROTATE_CLOUD_CREDENTIALS: "true" | ||
| TEST_SUITE: openshift/conformance/parallel | ||
| workflow: openshift-e2e-openstack-ipi | ||
| - as: e2e-openstack-ovn-serial |
There was a problem hiding this comment.
if we already have e2e-openstack-ovn-parallel do we really need the serial one?
Is there such a big difference in the test suite that is ran?
I'm just trying to reducing that amount of jobs that will run.
There was a problem hiding this comment.
The two suites run different tests. In particular: the "serial" suite runs tests that are susceptible to break each other, hence they're run without parallelisation. If I remember correctly, the rationale for having two suites (rather than running all serial-only, then all parallelisable tests) is that they're simply too many.
Coming back in scope of this particular PR: I am doublig the intervals of the Terraform-based jobs at the same time that I add the CAPI-based ones. The idea is that we should end up with the same exact number of jobs (except those that run very seldom, which I have not touched).
| memory: 200Mi | ||
| tests: | ||
| - as: e2e-openstack-fips | ||
| minimum_interval: 56h |
There was a problem hiding this comment.
I see the new jobs have the same minimum_interval as the periodics without CAPI.
Is there a chance jobs with the same minimum_interval will run at the same time? we might see etcd issues if that is true. I suggest tweaking this a bit.
There was a problem hiding this comment.
We designed minimum_interval to address this problem exactly: each job's interval will start after it's completed, rather than after it started. As a consequence, jobs delayed because they couldn't immediately acquire a lease are naturally moved forward until they find a stable spot.
|
Why isn't CAPI baked in? |
|
@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
pierreprinetti
force-pushed
the
os_capi_periodics
branch
from
b25f2d1
to
2183e2b
Compare
|
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ovn-password |
1 similar comment
|
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-capi-periodic-4.16-e2e-openstack-ovn-password |
|
@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
pierreprinetti
force-pushed
the
os_capi_periodics
branch
from
2183e2b
to
8d593f6
Compare
openshift-ci
bot
removed
the
approved
|
/test ordered-prow-config |
|
@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Reduce the frequency of regular Terraform-based jobs to adjust. Add the OpenStack periodics under openshift/installer, because we can't have them in shiftstack/shiftstack-ci until the CAPI providers are added to the release payload.
pierreprinetti
force-pushed
the
os_capi_periodics
branch
from
8d593f6
to
38c1e00
Compare
|
Fixed |
|
@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@pierreprinetti: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[REHEARSALNOTIFIER]
A total of 29 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
There was a problem hiding this comment.
/approve
I'm happy to add more ci testing to the altinfra image, but I would expect this to be a very short-lived temporary arrangement leading up to 4.16 GA. Once we get the capi installer in the release image, which will hopefully be any day, we will need to make further adjustments.
| - as: e2e-openstack-fips | ||
| minimum_interval: 56h | ||
| steps: | ||
| cluster_profile: openstack-vexxhost | ||
| env: | ||
| FEATURE_GATES: ClusterAPIInstall=true | ||
| FEATURE_SET: CustomNoUpgrade | ||
| FIPS_ENABLED: "true" | ||
| TEST_SUITE: experimental/reliability/minimal | ||
| pre: | ||
| - chain: ipi-openstack-pre | ||
| - ref: fips-check | ||
| workflow: openshift-e2e-openstack-ipi |
There was a problem hiding this comment.
This altinfra image is not fips compliant so you may need to set OPENSHIFT_INSTALL_SKIP_HOSTCRYPT_VALIDATION="true" to skip the installer host validation. We could do that in a followup pr once we observe failures.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, patrickdillon, pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
|
@pierreprinetti: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Reduce the frequency of regular Terraform-based jobs to adjust. Add the OpenStack periodics under openshift/installer, because we can't have them in shiftstack/shiftstack-ci until the CAPI providers are added to the release payload.
Reduce the frequency of regular Terraform-based jobs to adjust. Add the OpenStack periodics under openshift/installer, because we can't have them in shiftstack/shiftstack-ci until the CAPI providers are added to the release payload.
Reduce the frequency of regular Terraform-based jobs to adjust.