Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ovn config helper functions to util lib #51771

Merged
merged 1 commit into from
May 9, 2024
Merged

move ovn config helper functions to util lib #51771

merged 1 commit into from
May 9, 2024

Conversation

jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented May 7, 2024 •
edited by openshift-ci bot

planning to use this for work on SDN-4776 [0] which covers more day-2 configs

@openshift-ci openshift-ci bot requested review from danwinship and dougbtv May 7, 2024 18:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/test e2e-aws-ovn-clusternetwork-cidr-expansion

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@jluhrsen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test build09-dry
  • /test build10-dry
  • /test check-gh-automation
  • /test check-gh-automation-tide
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hosted-mgmt-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test stackrox-stackrox-stackrox-stackrox-check
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test vsphere02-dry
  • /test yamllint

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint

In response to this:

/test e2e-aws-ovn-clusternetwork-cidr-expansion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo204902960/ci-operator/step-registry/ovn/utils/utils.sh has incorrect prefix. Prefix should be ovn-utils
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo877457651/ci-operator/step-registry/ovn/utils/utils.sh has incorrect prefix. Prefix should be ovn-utils

If the problem persists, please contact Test Platform.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo1592994367/ci-operator/step-registry/ovn/utils/utils.sh has incorrect prefix. Prefix should be ovn-utils
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo1063409940/ci-operator/step-registry/ovn/utils/utils.sh has incorrect prefix. Prefix should be ovn-utils

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: file /var/tmp/gitrepo2716846898/ci-operator/step-registry/ovn/ovn-utils/ovn-utils.sh has incorrect prefix. Prefix should be ovn-ovn-utils
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: invalid file name: /var/tmp/gitrepo606314246/ci-operator/step-registry/ovn/utils/ovn-utils.sh
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: invalid file name: /var/tmp/gitrepo744843070/ci-operator/step-registry/ovn/utils/ovn-utils.sh

If the problem persists, please contact Test Platform.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 8, 2024

@danwinship , thank you for reviewing this PR :)

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 8, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build05: failed waiting for imagestreamtag ocp/cli:latest to appear: get failed: client rate limiter Wait returned an error: context deadline exceeded

If the problem persists, please contact Test Platform.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 8, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 9, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 9, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jluhrsen
move ovn config helper functions to util lib
d284350 
planning to use this for work on SDN-4776 [0] which covers
more day-2 configs

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 9, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jluhrsen: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-clusternetwork-cidr-expansion openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.17-e2e-aws-ovn-clusternetwork-cidr-expansion openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.16-e2e-aws-ovn-clusternetwork-cidr-expansion openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-clusternetwork-cidr-expansion openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-clusternetwork-cidr-expansion openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.14-e2e-aws-ovn-clusternetwork-cidr-expansion-presubmit openshift/cluster-network-operator presubmit Registry content changed
periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion N/A periodic Registry content changed
periodic-ci-openshift-cluster-network-operator-release-4.15-e2e-aws-ovn-clusternetwork-cidr-expansion N/A periodic Registry content changed
periodic-ci-openshift-cluster-network-operator-release-4.14-e2e-aws-ovn-clusternetwork-cidr-expansion N/A periodic Registry content changed
periodic-ci-openshift-cluster-network-operator-release-4.13-e2e-aws-ovn-clusternetwork-cidr-expansion N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 9, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2024
wking
wking approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@wking wking left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the content is small enough to fit into the Secret backing SHARED_DIR, I guess this works. And reverts or other pivots should be fairly straightforward if we do run into trouble.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-network-operator/release-4.14/e2e-aws-ovn-clusternetwork-cidr-expansion-presubmit b27fbee link unknown /pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-aws-ovn-clusternetwork-cidr-expansion-presubmit
ci/rehearse/openshift/ovn-kubernetes/release-4.14/e2e-aws-ovn-clusternetwork-cidr-expansion d284350 link unknown /pj-rehearse pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-clusternetwork-cidr-expansion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 946a917 into openshift:master May 9, 2024
16 of 17 checks passed
jbpratt pushed a commit to jbpratt/release that referenced this pull request May 30, 2024
@jluhrsen @jbpratt
move ovn config helper functions to util lib (openshift#51771)
f18e2df 
planning to use this for work on SDN-4776 [0] which covers
more day-2 configs

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@wking wking wking approved these changes

@dougbtv dougbtv Awaiting requested review from dougbtv

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@jluhrsen @openshift-ci-robot @danwinship @wking