WIP: Enable day2 add node using agent-install in disconnected envs #51813
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| #oinst agent create image | ||
| ### Copy the image to the auxiliary host | ||
| echo -e "\nCopying the day2 node ISO image into the bastion host..." | ||
| scp "${SSHOPTS[@]}" "${INSTALL_DIR}/node.x86_64.iso" "root@${AUX_HOST}:/opt/html/${CLUSTER_NAME}.node.iso" |
There was a problem hiding this comment.
note that this should consider other arch, and heterogeneous clusters too (day2 nodes of a different architecture than the control plane).
cc @zniu1011
There was a problem hiding this comment.
Multiarch is not supported in the initial version of node-joiner.sh, intend to support in the onwards versions or probably be supported in oc command line which is planning in 4.17, https://issues.redhat.com/browse/AGENT-838. We can consider to use agent day2 install way for the heterogeneous cases on the Agent side then.
There was a problem hiding this comment.
cc @jeffdyoung are you aware of this in the efforts regarding https://issues.redhat.com/browse/MULTIARCH-4258 ?
There was a problem hiding this comment.
@aleskandro yes, we know about agent day2. We haven't prioritized multi-arch there yet. My best guess would be 4.18?
There was a problem hiding this comment.
@aleskandro , arm64 is not supported yet. https://github.com/openshift/installer/blob/master/docs/user/agent/add-node/node-joiner.sh
There was a problem hiding this comment.
@aleskandro yes, we know about agent day2. We haven't prioritized multi-arch there yet. My best guess would be 4.18?
Do we have a story/epic for this already? Do we also need one for arm64 at this point?
|
/test e2e-metal-ipi-ovn-ipv6 (wrong pr :D) |
|
@aleskandro: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-ci-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-ci-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-ci-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
bmanzari
force-pushed
the
AGENT-682
branch
3 times, most recently
from
cf1a56a
to
9b99ce0
Compare
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-ci-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetal-compact-abi-ipv4-static-disc-day2-f7 |
|
@bmanzari: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
bmanzari
force-pushed
the
AGENT-682
branch
2 times, most recently
from
7fd5704
to
f3420b7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bmanzari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 141 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@bmanzari: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.