SDN-4776: add e2e-aws-ovn-subnet-configs job #51970
Conversation
jluhrsen
commented
May 13, 2024
jluhrsen
commented
- adds new step to do day-2 config for internalTransitSwitchSubnet
- adds new step to do day-2 config for internalJoinSubnet
- job uses a clusternetwork manifest so that the cluster install will have a configured internalMasqueradeSubnet
- the job will run periodically using the CNO repo
openshift-ci-robot
added
the
jira/valid-reference
|
@jluhrsen: This pull request references SDN-4776 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-subnet-configs |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jluhrsen
changed the title
|
@jluhrsen I believe we should be ok now as https://issues.redhat.com/browse/OCPBUGS-33728 was merged yesterday |
|
/pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-subnet-configs |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-subnet-configs |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-subnet-configs |
openshift-ci-robot
removed
the
rehearsals-ack
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| internalTransitSwitchSubnet=$(oc get network.operator.openshift.io -o jsonpath='{.items[0].spec.defaultNetwork.ovnKubernetesConfig.ipv4.internalTransitSwitchSubnet}') | ||
|
|
||
| # first wait for the network operator to move to Progressing=True | ||
| wait_for_operator_to_be_progressing network | ||
|
|
||
| # make sure all operators and nodes are good | ||
| wait_for_operators_and_nodes 300 | ||
|
|
||
| if [[ "$internalTransitSwitchSubnet" != "100.69.0.0/16" ]]; then | ||
| echo "Error: internalTransitSwitchSubnet is misconfigured. Expected internalTransitSwitchSubnet of 100.69.0.0/16, but got:" | ||
| oc get network.operator.openshift.io -o jsonpath='{.items[0].spec.defaultNetwork}' | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
I don't really understand why you check internalTransitSwitchSubnet. Either at all (since it would mean that the patch command that did not fail didn't work, so testing the patch command?) and also why you do it after the operators stabilize but with the value you got before they did.
There was a problem hiding this comment.
I guess the same comment would apply for the internalJoinSubnet.
Probably missing something that could be clarified through a comment
There was a problem hiding this comment.
great catch here. the intention was to do the patch, then let the operator to progress and settle, then validate that
it's present in network.opertor.
I just updated the PR to do that with a small comment.
Thanks for this.
| internalMasqueradeSubnet: 100.254.169.0/29 | ||
| EOF | ||
|
|
||
| cat ${SHARED_DIR}/manifest_cluster-network-03-config.yml |
There was a problem hiding this comment.
Out of curiosity, are all manifests in ${SHARED_DIR} among all the other files in there, picked up for installation? or is there any more specific criteria?
There was a problem hiding this comment.
great question. I don't actually know the answer, just following the pattern that was there since the beginning for me :)
| internalMasqueradeSubnet: 100.254.169.0/29 | ||
| EOF | ||
|
|
||
| cat ${SHARED_DIR}/manifest_cluster-network-03-config.yml |
There was a problem hiding this comment.
A lot of the files don't end with an empty new line, unsure if that's an issue
There was a problem hiding this comment.
no, I don't think it's an issue as the jobs work as expected. I've seen both with and without I think. not sure if we have a standard to follow on this.
- adds new step to do day-2 config for internalTransitSwitchSubnet - adds new step to do day-2 config for internalJoinSubnet - job uses a clusternetwork manifest so that the cluster install will have a configured internalMasqueradeSubnet - adds a step post-install that will check that the internalMasqueradeSubnet route is configured in every node's route table - the job will run periodically using the CNO repo Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
|
/pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-subnet-configs |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-subnet-configs |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jluhrsen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jcaamano , I think this is good now if you could check please. |
|
/pj-rehearse ack |
|
@jluhrsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, jluhrsen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
