CI build for AMD Tensorflow & Pytorch #53309

dibryant · 2024-06-17T18:44:19Z

Fixes for https://issues.redhat.com/browse/RHOAIENG-6377
Contributing to PR: opendatahub-io/notebooks#557
Adding CI builds for AMD Pytorch and Tensorflow.

openshift-ci · 2024-06-17T18:46:20Z

Hi @dibryant. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2024-06-17T18:46:59Z

@dibryant, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error converting YAML to JSON: yaml: line 60: did not find expected key)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci-robot · 2024-06-17T18:53:26Z

@dibryant, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error converting YAML to JSON: yaml: line 60: did not find expected key)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

harshad16 · 2024-06-20T19:30:15Z

/ok-to-test

openshift-ci-robot · 2024-06-20T21:06:45Z

@dibryant, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: failed to load ci-operator config (error converting YAML to JSON: yaml: line 60: did not find expected key)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

atheo89

Added some review commends. Once you pass this PR from a second iteration of fixes you will need to run on your PC make job this will auto generate some files that will fix the complaining jobs

atheo89 · 2024-06-21T08:17:09Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

@@ -58,7 +58,7 @@ images:
 - context_dir: base/ubi9-python-3.9
  dockerfile_path: Dockerfile
  to: base-ubi9-python-3.9
- context_dir: jupyter/minimal/ubi9-python-3.9
+  - context_dir: jupyter/minimal/ubi9-python-3.9


Remove the space

Suggested change

- context_dir: jupyter/minimal/ubi9-python-3.9

- context_dir: jupyter/minimal/ubi9-python-3.9

atheo89 · 2024-06-21T08:27:00Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

+  run_if_changed: (base\/ubi9-python-3.9\/*)|(jupyter\/tensorflow\/ubi9-python-3.9\/*)|(jupyter\/datacience\/ubi9-python-3.9\/*)|(jupyter\/tensorflow\/ubi9-python-3.9\/*)
+  steps:
+    dependencies:
+      SOURCE_IMAGE_REF: jupyter-amd-tensorflow-ubi9-python-3.9
+    env:
+      IMAGE_REPO: workbench-images
+      IMAGE_TAG: YearIndex
+      RELEASE_VERSION: jupyter-amd-tensorflow-ubi9-python-3.9
+    workflow: opendatahub-io-ci-image-mirror


Hmm what is that block? This is could be removed i guess, since you have already added on the lines 974-993

atheo89 · 2024-06-21T08:33:48Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

+      IMAGE_REPO: workbench-images
+      IMAGE_TAG: YearIndex
+      RELEASE_VERSION: jupyter-amd-tensorflow-ubi9-python-3.9
+    workflow: opendatahub-io-ci-image-mirror
 - as: notebooks-e2e-tests
  skip_if_only_changed: ^docs\/|.github\/workflows\/*|\\.(md)$|^(\.gitignore|LICENSE|OWNERS|PROJECT)$


You will also need to add e2e test section:
This should be added under habana-notebooks-e2e-tests job and you may call it as amd-notebooks-e2e-test
In there you will need to do something similar that we do for the rest.

openshift-ci-robot · 2024-06-25T16:14:34Z

@dibryant, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

harshad16

Thank you for the awesome work
some comments.

harshad16 · 2024-06-25T16:49:25Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

+  dockerfile_path: Dockerfile
+  from: amd-jupyter-minimal-ubi9-python-3.9
+  to: amd-jupyter-datascience-ubi9-python-3.9
+- context_dir: jupyter/tensorflow/ubi9-python-3.9


Suggested change

- context_dir: jupyter/tensorflow/ubi9-python-3.9

- context_dir: jupyter/amd/tensorflow/ubi9-python-3.9

harshad16 · 2024-06-25T16:49:59Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

+  dockerfile_path: Dockerfile
+  from: amd-jupyter-datascience-ubi9-python-3.9
+  to: amd-jupyter-tensorflow-ubi9-python-3.9
+- context_dir: jupyter/pytorch/ubi9-python-3.9


Suggested change

- context_dir: jupyter/pytorch/ubi9-python-3.9

- context_dir: jupyter/amd/pytorch/ubi9-python-3.9

harshad16 · 2024-06-25T16:53:43Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

+- as: notebook-amd-jupyter-ds-ubi9-python-3-9-image-mirror
+  postsubmit: true
+  steps:
+    dependencies:
+      SOURCE_IMAGE_REF: amd-jupyter-datascience-ubi9-python-3.9
+    env:
+      IMAGE_REPO: workbench-images
+      IMAGE_TAG: YearIndex
+      RELEASE_VERSION: amd-jupyter-datascience-ubi9-python-3.9
+    workflow: opendatahub-io-ci-image-mirror


For now, we can drop the AMD data-science and minimal, as we are not gonna provide them in.
leaving this for future.

Remove these lines, and the minimal as well, as we don't really provide them to the user.

harshad16 · 2024-06-25T16:56:49Z

ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

@@ -160,7 +160,19 @@ images:
 - context_dir: jupyter/minimal/ubi9-python-3.9
  dockerfile_path: Dockerfile
  from: amd-c9s-python-3.9
-  to: amd-jupyter-minimal-c9s-python-3.9
+  to: amd-jupyter-minimal-ubi9-python-3.9


Suggested change

to: amd-jupyter-minimal-ubi9-python-3.9

to: amd-jupyter-minimal-c9s-python-3.9

Even though we use the directory, ubi9-python-3.9
we are still basing these on centos , so we should use the centos in naming them
can you do this for the below ones as well.

openshift-ci-robot · 2024-07-17T14:12:25Z

@dibryant, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: [failed to load ci-operator configuration from release repo: invalid ci-operator config: configuration has 12 errors:

 * images[41]: duplicate image name 'rocm-jupyter-minimal-ubi9-python-3.9' (previously defined by field 'images[38]')
 * images[42]: duplicate image name 'rocm-jupyter-datascience-ubi9-python-3.9' (previously defined by field 'images[39]')
 * images[43]: duplicate image name 'rocm-jupyter-tensorflow-ubi9-python-3.9' (previously defined by field 'images[40]')
 * tests: found duplicated test: (notebook-rocm-ubi9-python-3-9-image-mirror,notebook-rocm-ubi9-python-3-9-pr-image-mirror,notebook-rocm-jupyter-tf-ubi9-python-3-9-image-mirror,notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror,notebook-rocm-jupyter-pyt-ubi9-python-3-9-image-mirror,notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror,rocm-notebooks-e2e-tests)
 * tests[72]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[72] has no type, you may want to specify 'container' for a container based test
 * tests[74]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[74] has no type, you may want to specify 'container' for a container based test
 * tests[76]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[76] has no type, you may want to specify 'container' for a container based test
 * tests[78]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[78] has no type, you may want to specify 'container' for a container based test
, failed to load Prow configuration from release repo: could not set regex: for job pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror, rerun command "/test notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror" does not match trigger "(?m)^/test( | .* )notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror,?($|\s.*)"]

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci-robot · 2024-07-17T15:11:07Z

@dibryant, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: [failed to load ci-operator configuration from release repo: invalid ci-operator config: configuration has 12 errors:

 * images[41]: duplicate image name 'rocm-jupyter-minimal-ubi9-python-3.9' (previously defined by field 'images[38]')
 * images[42]: duplicate image name 'rocm-jupyter-datascience-ubi9-python-3.9' (previously defined by field 'images[39]')
 * images[43]: duplicate image name 'rocm-jupyter-tensorflow-ubi9-python-3.9' (previously defined by field 'images[40]')
 * tests: found duplicated test: (notebook-rocm-ubi9-python-3-9-image-mirror,notebook-rocm-ubi9-python-3-9-pr-image-mirror,notebook-rocm-jupyter-tf-ubi9-python-3-9-image-mirror,notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror,notebook-rocm-jupyter-pyt-ubi9-python-3-9-image-mirror,notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror,rocm-notebooks-e2e-tests)
 * tests[72]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[72] has no type, you may want to specify 'container' for a container based test
 * tests[74]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[74] has no type, you may want to specify 'container' for a container based test
 * tests[76]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[76] has no type, you may want to specify 'container' for a container based test
 * tests[78]: either `commands`, `steps`, or `literal_steps` should be set
 * tests[78] has no type, you may want to specify 'container' for a container based test
, failed to load Prow configuration from release repo: could not set regex: for job pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror, rerun command "/test notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror" does not match trigger "(?m)^/test( | .* )notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror,?($|\s.*)"]

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2024-07-17T15:23:57Z

@dibryant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/opendatahub-io/notebooks/main/rocm-notebooks-e2e-tests	`50b9139`	link	unknown	`/pj-rehearse pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests`
ci/rehearse/opendatahub-io/notebooks/main/notebook-rocm-jupyter-tf-c9s-python-3-9-pr-image-mirror	`50b9139`	link	unknown	`/pj-rehearse pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-tf-c9s-python-3-9-pr-image-mirror`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

harshad16

/lgtm
/approve
/unhold
/pj-rehearse ack
thanks 👍

openshift-ci-robot · 2024-07-19T15:06:04Z

[REHEARSALNOTIFIER]
@dibryant: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-pyt-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-jupyter-tf-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-rocm-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Presubmit changed
pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests	opendatahub-io/notebooks	presubmit	Presubmit changed
pull-ci-opendatahub-io-notebooks-main-amd-runtimes-ubi9-e2e-tests	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-anaconda-ubi8-e2e-tests	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-codeserver-notebook-e2e-tests	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-habana-notebooks-e2e-tests	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-images	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-intel-notebooks-e2e-tests	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-jupyter-datascience-anaconda-python-3-8-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-c9s-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi8-python-3-8-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-codeserver-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-c9s-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi8-python-3-8-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi9-python-3-9-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror	opendatahub-io/notebooks	presubmit	Ci-operator config changed

A total of 53 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

harshad16 · 2024-07-19T15:20:57Z

/lgtm
/approve
/pj-rehearse ack
thanks 👍

openshift-ci-robot · 2024-07-19T15:21:00Z

@harshad16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2024-07-19T15:21:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, dibryant, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/config/opendatahub-io/notebooks/OWNERS~~ [atheo89,harshad16]
~~ci-operator/jobs/opendatahub-io/notebooks/OWNERS~~ [atheo89,harshad16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2024

openshift-ci bot requested review from atheo89 and harshad16 June 17, 2024 18:46

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2024

dibryant force-pushed the amd branch from c32ad68 to 3a3c156 Compare June 17, 2024 18:52

dibryant changed the title ~~Amd~~ [WIP] Amd Jun 17, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2024

dibryant changed the title ~~[WIP] Amd~~ [WIP] CI build for AMD Tensorflow & Pytorch Jun 20, 2024

openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2024

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2024

dibryant force-pushed the amd branch from 3a3c156 to 74ab0a9 Compare June 20, 2024 21:05

atheo89 suggested changes Jun 21, 2024

View reviewed changes

openshift-ci bot assigned atheo89 Jun 21, 2024

atheo89 mentioned this pull request Jun 24, 2024

Setup build images for Pytorch & Tensorflow with base ROCm image opendatahub-io/notebooks#557

Merged

3 tasks

dibryant force-pushed the amd branch from 74ab0a9 to 23ebbaf Compare June 25, 2024 16:13

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2024

dibryant force-pushed the amd branch from 23ebbaf to 85e3d30 Compare June 25, 2024 16:39

harshad16 suggested changes Jun 25, 2024

View reviewed changes

openshift-ci bot assigned harshad16 Jun 25, 2024

dibryant force-pushed the amd branch from 85e3d30 to 64b3ec9 Compare June 25, 2024 22:28

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2024

dibryant force-pushed the amd branch 2 times, most recently from 26a52ab to 4f31061 Compare June 25, 2024 22:31

openshift-ci-robot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels Jul 17, 2024

dibryant force-pushed the amd branch from ba00d37 to 34aaf5a Compare July 17, 2024 14:11

dibryant force-pushed the amd branch from 34aaf5a to 11e1c58 Compare July 17, 2024 15:09

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024

dibryant force-pushed the amd branch from 11e1c58 to 4a98641 Compare July 17, 2024 15:27

harshad16 approved these changes Jul 19, 2024

View reviewed changes

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 19, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2024

dibryant force-pushed the amd branch from 4a98641 to 07ad0f9 Compare July 19, 2024 13:09

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2024

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024

atheo89 mentioned this pull request Jul 19, 2024

[ODH] Follow up to onboard jobs for rocm-tensorflow #54579

Merged

setup ci for rocm pytorch and tensorflow

e6f1fea

dibryant force-pushed the amd branch from 07ad0f9 to e6f1fea Compare July 19, 2024 15:04

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 19, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024

openshift-merge-bot bot merged commit c9ae12a into openshift:master Jul 19, 2024
17 checks passed

aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024

setup ci for rocm pytorch and tensorflow (openshift#53309)

abc38b3

aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024

setup ci for rocm pytorch and tensorflow (openshift#53309)

cd8f721

dibryant deleted the amd branch July 24, 2024 13:14

dibryant mentioned this pull request Jul 24, 2024

CI build for ROCM Base, Tensorflow, Pytorch & Runtime 2024a #54777

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI build for AMD Tensorflow & Pytorch #53309

CI build for AMD Tensorflow & Pytorch #53309

dibryant commented Jun 17, 2024 •

edited

Loading

openshift-ci bot commented Jun 17, 2024

openshift-ci-robot commented Jun 17, 2024

openshift-ci-robot commented Jun 17, 2024

harshad16 commented Jun 20, 2024

openshift-ci-robot commented Jun 20, 2024

atheo89 left a comment

atheo89 Jun 21, 2024

atheo89 Jun 21, 2024

atheo89 Jun 21, 2024

openshift-ci-robot commented Jun 25, 2024

harshad16 left a comment

harshad16 Jun 25, 2024

harshad16 Jun 25, 2024

harshad16 Jun 25, 2024

harshad16 Jun 25, 2024

openshift-ci-robot commented Jul 17, 2024

openshift-ci-robot commented Jul 17, 2024

openshift-ci bot commented Jul 17, 2024 •

edited

Loading

harshad16 left a comment

openshift-ci-robot commented Jul 19, 2024

harshad16 commented Jul 19, 2024

openshift-ci-robot commented Jul 19, 2024

openshift-ci bot commented Jul 19, 2024

	- context_dir: jupyter/minimal/ubi9-python-3.9
	- context_dir: jupyter/minimal/ubi9-python-3.9

	- context_dir: jupyter/tensorflow/ubi9-python-3.9
	- context_dir: jupyter/amd/tensorflow/ubi9-python-3.9

	- context_dir: jupyter/pytorch/ubi9-python-3.9
	- context_dir: jupyter/amd/pytorch/ubi9-python-3.9

	to: amd-jupyter-minimal-ubi9-python-3.9
	to: amd-jupyter-minimal-c9s-python-3.9

CI build for AMD Tensorflow & Pytorch #53309

CI build for AMD Tensorflow & Pytorch #53309

Conversation

dibryant commented Jun 17, 2024 • edited Loading

openshift-ci bot commented Jun 17, 2024

openshift-ci-robot commented Jun 17, 2024

openshift-ci-robot commented Jun 17, 2024

harshad16 commented Jun 20, 2024

openshift-ci-robot commented Jun 20, 2024

atheo89 left a comment

Choose a reason for hiding this comment

atheo89 Jun 21, 2024

Choose a reason for hiding this comment

atheo89 Jun 21, 2024

Choose a reason for hiding this comment

atheo89 Jun 21, 2024

Choose a reason for hiding this comment

openshift-ci-robot commented Jun 25, 2024

harshad16 left a comment

Choose a reason for hiding this comment

harshad16 Jun 25, 2024

Choose a reason for hiding this comment

harshad16 Jun 25, 2024

Choose a reason for hiding this comment

harshad16 Jun 25, 2024

Choose a reason for hiding this comment

harshad16 Jun 25, 2024

Choose a reason for hiding this comment

openshift-ci-robot commented Jul 17, 2024

openshift-ci-robot commented Jul 17, 2024

openshift-ci bot commented Jul 17, 2024 • edited Loading

harshad16 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jul 19, 2024

harshad16 commented Jul 19, 2024

openshift-ci-robot commented Jul 19, 2024

openshift-ci bot commented Jul 19, 2024

dibryant commented Jun 17, 2024 •

edited

Loading

openshift-ci bot commented Jul 17, 2024 •

edited

Loading