Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade registry-operator tests to ocp 4.15 #53498

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jun 20, 2024

Upgrades the registry operator ci-operator-config and jobs to use ocp 4.15

Related to devfile/registry-operator#91

Fixes devfile/api#1559

Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@michael-valdron
Copy link
Member

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 20, 2024
Signed-off-by: thepetk <thepetk@gmail.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@thepetk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-devfile-registry-operator-main-v4.15-images devfile/registry-operator presubmit Presubmit changed
pull-ci-devfile-registry-operator-main-v4.15-registry-operator-integration-test devfile/registry-operator presubmit Presubmit changed
pull-ci-devfile-registry-operator-release-v0-v4.15-images devfile/registry-operator presubmit Presubmit changed
pull-ci-devfile-registry-operator-release-v0-v4.15-registry-operator-integration-test devfile/registry-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 21, 2024
@michael-valdron
Copy link
Member

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Once the rehearsal passes the PR can be put into the merge pool.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@michael-valdron: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b34a6ba into openshift:master Jun 21, 2024
20 of 21 checks passed
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@thepetk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cplacani pushed a commit to cplacani/release that referenced this pull request Jun 25, 2024
* Upgrade registry-operator jobs

Signed-off-by: thepetk <thepetk@gmail.com>

* Upgrade golang tag to 1.21

Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>
JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Jul 2, 2024
* Upgrade registry-operator jobs

Signed-off-by: thepetk <thepetk@gmail.com>

* Upgrade golang tag to 1.21

Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants