Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tripleo based zuul jobs non-blocking on libpod PRs #5668

Merged
merged 1 commit into from Nov 6, 2019
Merged

Make Tripleo based zuul jobs non-blocking on libpod PRs #5668

merged 1 commit into from Nov 6, 2019

Conversation

raukadah
Copy link
Contributor

TripleO, an Openstack deployment tool is one of the consumer of
podman to run OpenStack services in container. In order to avoid
breakage due to podman releases, TripleO based Zuul jobs are
getting added.

But libpod PRs are getting blocked due to zuul jobs failure.
In order to fix that, we are setting skip-unknown-contexts
to true makes the tide to ignore the zuul job result.

Signed-off-by: Chandan Kumar (raukadah) raukadah@gmail.com

TripleO, an Openstack deployment tool is one of the consumer of
podman to run OpenStack services in container. In order to avoid
breakage due to podman releases, TripleO based Zuul jobs are
getting added.

But libpod PRs are getting blocked due to zuul jobs failure.
In order to fix that, we are setting skip-unknown-contexts
to true makes the tide to ignore the zuul job result.

Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @raukadah. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2019
@droslean
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2019
@petr-muller
Copy link
Member

petr-muller commented Oct 30, 2019

/hold

@raukadah can you make someone from containers/libpod OWNERS (https://github.com/containers/libpod/blob/master/OWNERS) /lgtm this?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2019
@raukadah
Copy link
Contributor Author

raukadah commented Nov 4, 2019

/assign @baude

@openshift-ci-robot
Copy link
Contributor

@raukadah: GitHub didn't allow me to assign the following users: baude.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @baude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Member

EmilienM commented Nov 6, 2019

💯

@baude
Copy link
Contributor

baude commented Nov 6, 2019

looks fine to me?

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, raukadah, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit 39fc744 into openshift:master Nov 6, 2019
@openshift-ci-robot
Copy link
Contributor

@raukadah: Updated the following 2 configmaps:

  • config configmap in namespace release-controller-test at cluster default using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster default using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml

In response to this:

TripleO, an Openstack deployment tool is one of the consumer of
podman to run OpenStack services in container. In order to avoid
breakage due to podman releases, TripleO based Zuul jobs are
getting added.

But libpod PRs are getting blocked due to zuul jobs failure.
In order to fix that, we are setting skip-unknown-contexts
to true makes the tide to ignore the zuul job result.

Signed-off-by: Chandan Kumar (raukadah) raukadah@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
8 participants