Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crun tests to cri-o/cri-o presubmits #6687

Merged
merged 1 commit into from Jan 15, 2020
Merged

Add crun tests to cri-o/cri-o presubmits #6687

merged 1 commit into from Jan 15, 2020

Conversation

haircommander
Copy link
Member

to eventually be able to test cgroups v2

Signed-off-by: Peter Hunt pehunt@redhat.com

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2020
@haircommander
Copy link
Member Author

/retest

@haircommander
Add crun tests to cri-o/cri-o presubmits
42a2be5 
to eventually be able to test cgroups v2

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Member Author

PTAL @mrunalp @giuseppe @vrothberg @umohnani8

giuseppe
giuseppe approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 45451eb into openshift:master Jan 15, 2020
@openshift-ci-robot
Copy link
Contributor

@haircommander: Updated the job-config-master configmap in namespace ci at cluster default using the following files:

  • key cri-o-cri-o-master-presubmits.yaml using file ci-operator/jobs/cri-o/cri-o/cri-o-cri-o-master-presubmits.yaml

In response to this:

to eventually be able to test cgroups v2

Signed-off-by: Peter Hunt pehunt@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@runcom runcom Awaiting requested review from runcom

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@haircommander @openshift-ci-robot @giuseppe @openshift-merge-robot