Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: cloud-credential-provider: modify test targets and add verify-deps #8263

Merged
merged 1 commit into from
Apr 13, 2020
Merged

config: cloud-credential-provider: modify test targets and add verify-deps #8263

merged 1 commit into from
Apr 13, 2020

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Apr 9, 2020 •
edited

Moving to build-machinery standard targets introduced in openshift/cloud-credential-operator#177 and openshift/cloud-credential-operator#178

@sjenning
Copy link
Contributor Author

sjenning commented Apr 9, 2020

/hold
waiting on openshift/cloud-credential-operator#178 to merge then retest verify-deps

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@sjenning
Copy link
Contributor Author

sjenning commented Apr 9, 2020

openshift/cloud-credential-operator#178 merged
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@sjenning
Copy link
Contributor Author

sjenning commented Apr 9, 2020

/retest
after the release-* branch fast-forward

@joelddiaz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit eeaa243 into openshift:master Apr 13, 2020
@openshift-ci-robot
Copy link
Contributor

@sjenning: Updated the following 21 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master-presubmits.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.5.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.6.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-cloud-credential-operator-master.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.5.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5.yaml
  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-master.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-master.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-cloud-credential-operator-release-4.5.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.6.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster ci/api-build01-ci-devcluster-openshift-com:6443 using the following files:
    • key openshift-cloud-credential-operator-release-4.6.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6.yaml
  • job-config-4.5 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5-presubmits.yaml
  • job-config-4.5 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.5-presubmits.yaml using file ci-operator/jobs/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-master.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.5.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.6.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6.yaml
  • ci-operator-4.6-configs configmap in namespace ci-stg at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.6.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.6-presubmits.yaml using file ci-operator/jobs/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.6-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci-stg at cluster app.ci using the following files:
    • key openshift-cloud-credential-operator-master.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master.yaml
  • ci-operator-4.5-configs configmap in namespace ci-stg at cluster api.ci using the following files:
    • key openshift-cloud-credential-operator-release-4.5.yaml using file ci-operator/config/openshift/cloud-credential-operator/openshift-cloud-credential-operator-release-4.5.yaml

In response to this:

Moving to build-machinery standard targets introduced in openshift/cloud-credential-operator#177 and openshift/cloud-credential-operator#178

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@joelddiaz joelddiaz Awaiting requested review from joelddiaz

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

@abutcher abutcher Awaiting requested review from abutcher

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@dgoodwin dgoodwin

@joelddiaz joelddiaz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@sjenning @joelddiaz @openshift-ci-robot @dgoodwin @openshift-merge-robot