upi-gcp-install: enable 'master' name for control plane #9490
Conversation
openshift-ci-robot
added
the
approved
| MASTER0_IP=$(gcloud compute instances describe ${INFRA_ID}-m-0 --zone ${ZONE_0} --format json | jq -r .networkInterfaces[0].networkIP) | ||
| MASTER1_IP=$(gcloud compute instances describe ${INFRA_ID}-m-1 --zone ${ZONE_1} --format json | jq -r .networkInterfaces[0].networkIP) | ||
| MASTER2_IP=$(gcloud compute instances describe ${INFRA_ID}-m-2 --zone ${ZONE_2} --format json | jq -r .networkInterfaces[0].networkIP) | ||
| MASTER0_IP=$(gcloud compute instances describe ${INFRA_ID}-${MASTER}-0 --zone ${ZONE_0} --format json | jq -r .networkInterfaces[0].networkIP) |
There was a problem hiding this comment.
qq: is there no way to request the information from the deploymentmanager template that was deployed. i.e all the resources it created?
There was a problem hiding this comment.
There likely is, but that's not what is in our documentation. I'd like to make sure we are sticking to documentation as much as possible, since that's the point.
This change updates the upi-gcp-install step to be able to use the full word 'master' in the name of control plane nodes. It maintains compatiblity with the the older 'm' naming convention by looking at which one was used in the 05_control_plane.py template. openshift/installer#3713
jstuever
force-pushed
the
gcp_relax_clustername
branch
from
2fe600b
to
2695133
Compare
|
/test pj-rehearse |
|
@jstuever: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Running into the following bug https://bugzilla.redhat.com/show_bug.cgi?id=1844613: PR openshift/installer#3713 is designed to work around this bug, but it requires this PR to merge first. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jstuever: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change updates the upi-gcp-install step to be able to use the full word 'worker' in the name of compute nodes. It maintains compatiblity with the the older 'w' naming convention by looking at if 'm' or 'master' is used in control_plane.py per openshift#9490. openshift/installer#3713 openshift#9490
This change updates the upi-gcp-install step to be able to use the full
word 'master' in the name of control plane nodes. It maintains
compatiblity with the the older 'm' naming convention by looking at
which one was used in the 05_control_plane.py template.
openshift/installer#3713