ci-operator/step-registry/gather/aws-console: Pin 4.5 upi-installer #9791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
We need both 'oc' and 'aws' for this script. The upi-installer image has a complicated history with the 'aws' command: * openshift/installer@512f93dd30 (images/installer: add image that can be used to instal UPI platforms, 2019-03-22, master and release-4.0, openshift/installer#1456) added the epel-release and awscli RPMs. * openshift/installer@c7b7863b42 (image: remove unneeded packages, 2019-08-13, master and release-4.2, openshift/installer#2206) removed the epel-release and awscli RPMs, which were no longer avialable. * openshift/installer@665ba44f45 (Add AWS CLI to UPI image, 2020-03-13, master and release-4.5, openshift/installer#3292) installed 'aws' via curl. But that means that today the bundled upi-installer has no 'aws' for 4.4 and earlier, leading to errors like [1]: Gathering console logs for i-04151362d551668fe /bin/bash: line 39: aws: command not found error: failed to execute wrapped command: exit status 1 2020/06/18 23:52:50 Container test in pod e2e-aws-gather-aws-console failed, exit code 1, reason Error on 4.2. With this commit I reference the 4.5 image [2,3], because that has the commands I need, and we don't need anything that's particularly senstive to the command versions. [1]: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/382/pull-ci-openshift-cluster-version-operator-release-4.2-e2e-aws/1273733457419177984 [2]: https://github.com/openshift/ci-tools/blob/97d72735a969f11b210806970d523f1b63297905/pkg/webreg/webreg.go#L933-L946 [3]: https://github.com/openshift/ci-tools/blob/97d72735a969f11b210806970d523f1b63297905/pkg/webreg/webreg.go#L1267-L1279
wking
force-pushed
the
pin-aws-console-image
branch
from
75cd4eb
to
13cec2f
Compare
|
And here is an example of a 4.4 job with this step hitting the same failure mode. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rphillips
added a commit
to rphillips/release
that referenced
this pull request
Sep 14, 2023
Back in openshift#9791 we pinned 4.5 because it had aws , while 4.4 did not. We no longer need this step to be compatible with 4.4 or earlier installs. We do need to be compatible with 4.14, which no longer has en_US.utf8. And we need to work with 4.11, which does not have C.utf8. So pin 4.14, so we can rely on a UPI-installer image that's compatible with this script, so we can get clusters for all 4.11 and later releases. Don't worry that we won't be excercising 4.11, etc. upi-images, they don't change much.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Back in #9791 we pinned 4.5 because it had aws , while 4.4 did not. We no longer need this step to be compatible with 4.4 or earlier installs. We do need to be compatible with 4.14, which no longer has en_US.utf8. And we need to work with 4.11, which does not have C.utf8. So pin 4.14, so we can rely on a UPI-installer image that's compatible with this script, so we can get clusters for all 4.11 and later releases. Don't worry that we won't be excercising 4.11, etc. upi-images, they don't change much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need both
ocandawsfor this script. The upi-installer image has a complicated history with theawscommand:epel-releaseandawscliRPMs.epel-releaseandawscliRPMs, which were no longer avialable.awsvia curl.But that means that today the bundled upi-installer has no
awsfor 4.4 and earlier, leading to errors like:on 4.2. With this commit I reference the 4.5 image (docs here and here), because that has the commands I need, and we don't need anything that's particularly senstive to the command versions.