This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Bug 979992 - Support 'y'/'n' as single character options when interactive #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix non-interactive stty behavior. Keep backwards compatibility of agree for anyone in non-interactive mode. Also change "success" on app create to "done" to be consistent.
| @@ -15,6 +15,17 @@ class HighLineExtension < HighLine | |||
| end | |||
| end | |||
|
|
|||
| if HighLine::CHARACTER_MODE == 'stty' | |||
| def raw_no_echo_mode | |||
There was a problem hiding this comment.
do we need to protect against double calls for these?
There was a problem hiding this comment.
It's a direct copy from highline - their code has ensure blocks and we've never hit a problem. Your call on whether you think it's necessary.
|
reviewed, [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/3369/) (Image: devenv_3470) |
|
Evaluated for online up to 4d85213 |
|
[Test]ing while waiting on the merge queue |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/3369/) |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 9, 2013
…ing_for_non_interactive Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix non-interactive stty behavior. Keep backwards compatibility of agree for
anyone in non-interactive mode. Also change "success" on app create to "done"
to be consistent.
@liggitt review