This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Bug 994174 - rhc not displaying CLIENT_MESSAGE returned by broker #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -466,11 +466,27 @@ def parse_response(response) | |||
|
|
|||
| # Copy messages to each object | |||
| messages = Array(result['messages']).map do |m| | |||
| m['text'] if (m['field'] == 'result' || m['severity'] == 'result') && (m['severity'] != 'debug' || debug?) | |||
| m['text'] unless ((((m['field'] != 'result' && m['severity'] == 'info') || m['severity'] == 'debug') && !debug?) || m['severity'] == 'warning') | |||
There was a problem hiding this comment.
switch this to a case statement in a .select instead:
.select do |m|
severity, field = m.values_at('severity', 'field')
switch
case field == 'result'
true
end.map{ |m| m['text'].chomp }
The logic is too compact now
|
Reviewed, [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/4040/) (Image: devenv_3683) |
|
[Test]ing while waiting on the merge queue |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/4040/) |
|
Evaluated for online up to 28541a0 |
|
Origin Test Results: Waiting for stable build of 'origin_ami' |
openshift-bot
pushed a commit
that referenced
this pull request
Aug 21, 2013
…not_displayed Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.