This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
[origin_ui_112] Kerberos principal support #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/4947/) |
| end | ||
|
|
||
| if type == 'krb5-principal' | ||
| # TODO: validate krb5? |
There was a problem hiding this comment.
Hrm... this seems smelly. Not sure what else you can do, but it's a bit wierd.
|
How hard is it to add a test case to core_features.rb to add a key of type krb5-principal (even if the backned doesn't do anything with it)? Will that break through the stack? |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/4947/) (Image: devenv_3942) |
|
Evaluated for online up to b99c4da |
openshift-bot
pushed a commit
that referenced
this pull request
Oct 24, 2013
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.