Rotate osdCcsAdmin credentails on creation of each cluster #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
198dc5c
to
e94a826
Compare
jharrington22
changed the title
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
2 times, most recently
from
9f72f8c
to
853eac7
Compare
|
I'm wondering what happens during |
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
853eac7
to
7a6910a
Compare
|
@jharrington22: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
7a6910a
to
6a0fa06
Compare
|
/label tide/merge-method-squash |
openshift-ci-robot
added
the
tide/merge-method-squash
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
2 times, most recently
from
2b1cd81
to
420d605
Compare
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
420d605
to
500bb51
Compare
openshift-ci-robot
added
the
needs-rebase
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
500bb51
to
203346a
Compare
openshift-ci-robot
removed
the
needs-rebase
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
4 times, most recently
from
5aeaf2b
to
2859320
Compare
vkareh
reviewed
Nov 2, 2020
|
Apart from my comment about |
vkareh
reviewed
Nov 5, 2020
vkareh
reviewed
Nov 5, 2020
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
ca9471f
to
06a08c1
Compare
|
/hold cancel @vkareh comments addressed, thanks! |
openshift-ci-robot
removed
the
do-not-merge/hold
jharrington22
force-pushed
the
remove-cloudformation-outputs
branch
from
06a08c1
to
3e8ba26
Compare
|
/lgtm Thanks @jharrington22! :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jharrington22, vkareh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vkareh
added a commit
to vkareh/rosa
that referenced
this pull request
Nov 5, 2020
- refactor(init): verify permissions for osdccsadmin using ValidateSCP - machinepools: Support full CRUD operations for machine pools - Added validation for name - Added Details Page Link - machinepool: Allow managing 'default' machinepool - Rotate osdCcsAdmin credentails on creation of each cluster (openshift#118)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotate IAM access keys for the IAM user osdCcsAdmin user each time we use the client to create a cluster. There is no need to permanently store these credentials since they are only used on create, the cluster uses a completely different set of IAM credentials provisioned by this user.