Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-3570 | feat: Add FedRAMP Prod Sector Env aliases #1657

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

hunterkepley
Copy link
Contributor

We need to update ROSA CLI FedRAMP environment aliases to ensure a consistent experience with the FedRAMP Keycloak go-live.

pkg/fedramp/config.go Outdated Show resolved Hide resolved
@hunterkepley hunterkepley changed the title OCM-3570 | feat: Add FedRAMP Prod Sector Env aliases Draft: OCM-3570 | feat: Add FedRAMP Prod Sector Env aliases Dec 11, 2023
@hunterkepley hunterkepley marked this pull request as draft December 11, 2023 20:10
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2023
@hunterkepley hunterkepley self-assigned this Dec 11, 2023
@hunterkepley hunterkepley marked this pull request as ready for review December 11, 2023 20:16
@hunterkepley hunterkepley changed the title Draft: OCM-3570 | feat: Add FedRAMP Prod Sector Env aliases OCM-3570 | feat: Add FedRAMP Prod Sector Env aliases Dec 11, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2023
@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
@tylercreller
Copy link
Member

LGTM

@gdbranco
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidleerh, gdbranco, hunterkepley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

@hunterkepley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 39ec3f1 into openshift:master Dec 13, 2023
6 checks passed
@hunterkepley hunterkepley deleted the ocm-3570 branch December 13, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants