Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6652 | task: update --best-effort help message #1840

Merged

Conversation

@ciaranRoche
Copy link
Member

@thomasmckay task is not one of the expected key words for the commit message

These are the expected keys

feat|fix|docs|style|refactor|test|chore|build|ci|perf

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@thomasmckay: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.45%. Comparing base (fa73f1c) to head (afda9f6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1840   +/-   ##
=======================================
  Coverage   21.45%   21.45%           
=======================================
  Files         113      113           
  Lines       18664    18664           
=======================================
  Hits         4005     4005           
  Misses      14351    14351           
  Partials      308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ciaranRoche
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, thomasmckay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7e70dcd into openshift:master Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants