-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-4460 | feat: Add actions for break glass credential #1855
Conversation
Skipping CI for Draft Pull Request. |
28183f8
to
a558a46
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
+ Coverage 21.49% 21.79% +0.30%
==========================================
Files 113 117 +4
Lines 18667 18963 +296
==========================================
+ Hits 4012 4133 +121
- Misses 14349 14519 +170
- Partials 306 311 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a1f20e6
to
672a632
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per discussion, slight rework to this PR to make the core workflows easier to handle.
/retest |
|
||
ocm.AddClusterFlag(Cmd) | ||
|
||
interactive.AddFlag(flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenz4027 You could just pass Cmd.Flags()
here rather than assigning the flags
variable. Not a biggie.
Thanks @robpblake , I'll add more test coverage as suggested. |
4975e84
to
ea592c4
Compare
Signed-off-by: Maggie Chen <magchen@redhat.com> add the remaining functions Signed-off-by: Maggie Chen <magchen@redhat.com> remove delete to revoke Signed-off-by: Maggie Chen <magchen@redhat.com> add tests Signed-off-by: Maggie Chen <magchen@redhat.com> fix lint Signed-off-by: Maggie Chen <magchen@redhat.com> fix the json Signed-off-by: Maggie Chen <magchen@redhat.com> refactor Signed-off-by: Maggie Chen <magchen@redhat.com> refactor Signed-off-by: Maggie Chen <magchen@redhat.com> change to clusterkey Signed-off-by: Maggie Chen <magchen@redhat.com> refactor Signed-off-by: Maggie Chen <magchen@redhat.com> add poll Signed-off-by: Maggie Chen <magchen@redhat.com> add more test coverage Signed-off-by: Maggie Chen <magchen@redhat.com> fix fmt Signed-off-by: Maggie Chen <magchen@redhat.com> add test Signed-off-by: Maggie Chen <magchen@redhat.com> fix fmt Signed-off-by: Maggie Chen <magchen@redhat.com> add test Signed-off-by: Maggie Chen <magchen@redhat.com> use .id instead Signed-off-by: Maggie Chen <magchen@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreadecorte, chenz4027, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chenz4027: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OCM-4460