Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6926 | fix: needs to also go through admin fedramp url aliases #1872

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Mar 25, 2024

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@gdbranco: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.49%. Comparing base (94a5865) to head (2942790).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1872      +/-   ##
==========================================
+ Coverage   21.47%   21.49%   +0.01%     
==========================================
  Files         113      113              
  Lines       18664    18667       +3     
==========================================
+ Hits         4009     4012       +3     
  Misses      14349    14349              
  Partials      306      306              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ciaranRoche
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,gdbranco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e8243ed into openshift:master Mar 26, 2024
9 checks passed
gdbranco pushed a commit that referenced this pull request Mar 26, 2024
OCM-6926 | fix: needs to also go through admin fedramp url aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants