-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6820 | fix: add checks for mandatory parameters #1884
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
- Coverage 21.81% 21.70% -0.11%
==========================================
Files 117 117
Lines 18929 19575 +646
==========================================
+ Hits 4129 4249 +120
- Misses 14489 14947 +458
- Partials 311 379 +68 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maggie Chen <magchen@redhat.com> refactor to avoid duplicate checks Signed-off-by: Maggie Chen <magchen@redhat.com>
if tests pass LGTM 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenz4027, ciaranRoche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
@chenz4027: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OCM-6820