Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6820 | fix: add checks for mandatory parameters #1884

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

chenz4027
Copy link
Contributor

@chenz4027 chenz4027 commented Mar 28, 2024

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 21.70%. Comparing base (0c0f1c3) to head (f61cbc9).
Report is 10 commits behind head on master.

Files Patch % Lines
pkg/externalauthprovider/flags.go 46.66% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   21.81%   21.70%   -0.11%     
==========================================
  Files         117      117              
  Lines       18929    19575     +646     
==========================================
+ Hits         4129     4249     +120     
- Misses      14489    14947     +458     
- Partials      311      379      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenz4027 chenz4027 changed the title OCM-6375 | fix: add checks for mandatory parameters OCM-6820 | fix: add checks for mandatory parameters Mar 28, 2024
Signed-off-by: Maggie Chen <magchen@redhat.com>

refactor to avoid duplicate checks

Signed-off-by: Maggie Chen <magchen@redhat.com>
@hunterkepley
Copy link
Contributor

if tests pass LGTM 🙂

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@chenz4027
Copy link
Contributor Author

/retest

2 similar comments
@chenz4027
Copy link
Contributor Author

/retest

@chenz4027
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 50a6168 into openshift:master Apr 2, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-6820 branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants