Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7168 | fix: Add info after successfully created breakglasscredentials #1901

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

chenz4027
Copy link
Contributor

@chenz4027 chenz4027 force-pushed the OCM-7168 branch 2 times, most recently from b5174a1 to 449b04c Compare April 4, 2024 18:13
@chenz4027
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 21.68%. Comparing base (0046b18) to head (a0f82a0).
Report is 4 commits behind head on master.

Files Patch % Lines
cmd/create/breakglasscredential/cmd.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1901      +/-   ##
==========================================
+ Coverage   21.61%   21.68%   +0.06%     
==========================================
  Files         118      118              
  Lines       19773    19779       +6     
==========================================
+ Hits         4274     4289      +15     
+ Misses      15177    15165      -12     
- Partials      322      325       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ials

Signed-off-by: Maggie Chen <magchen@redhat.com>

fix test

Signed-off-by: Maggie Chen <magchen@redhat.com>

ignore lint

Signed-off-by: Maggie Chen <magchen@redhat.com>

add test

Signed-off-by: Maggie Chen <magchen@redhat.com>
Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@robpblake
Copy link
Contributor

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8e6cd33 into openshift:master Apr 8, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-7168 branch April 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants