-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7168 | fix: Add info after successfully created breakglasscredentials #1901
Conversation
b5174a1
to
449b04c
Compare
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1901 +/- ##
==========================================
+ Coverage 21.61% 21.68% +0.06%
==========================================
Files 118 118
Lines 19773 19779 +6
==========================================
+ Hits 4274 4289 +15
+ Misses 15177 15165 -12
- Partials 322 325 +3 ☔ View full report in Codecov by Sentry. |
…ials Signed-off-by: Maggie Chen <magchen@redhat.com> fix test Signed-off-by: Maggie Chen <magchen@redhat.com> ignore lint Signed-off-by: Maggie Chen <magchen@redhat.com> add test Signed-off-by: Maggie Chen <magchen@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenz4027, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@chenz4027: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/OCM-7168