Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-5247 | fix: block HCP operator-roles with unmanaged policies acco… #1947

Merged
merged 1 commit into from Apr 19, 2024
Merged

OCM-5247 | fix: block HCP operator-roles with unmanaged policies acco… #1947

merged 1 commit into from Apr 19, 2024

Conversation

chenz4027
Copy link
Contributor

@chenz4027
OCM-5247 | fix: block HCP operator-roles with unmanaged policies acco…
edde3d4 
…unt role

Signed-off-by: Maggie Chen <magchen@redhat.com>

Empty commit

Signed-off-by: Maggie Chen <magchen@redhat.com>

fix lint

Signed-off-by: Maggie Chen <magchen@redhat.com>
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.43%. Comparing base (73ec2f3) to head (edde3d4).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #1947    +/-   ##
========================================
  Coverage   22.42%   22.43%            
========================================
  Files         126      129     +3     
  Lines       20113    20550   +437     
========================================
+ Hits         4511     4610    +99     
- Misses      15254    15592   +338     
  Partials      348      348

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robpblake
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 86498a9 into openshift:master Apr 19, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-5247 branch May 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robpblake robpblake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chenz4027 @robpblake