Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-5247 | fix: block HCP operator-roles with unmanaged policies acco… #1947

Merged
merged 1 commit into from
Apr 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/create/operatorroles/by_prefix.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,13 @@ func handleOperatorRoleCreationByPrefix(r *rosa.Runtime, env string,
r.Reporter.Errorf("Failed to determine if the Installer role ARN has hosted CP policies: %v", err)
os.Exit(1)
}

if !hostedCPPolicies {
r.Reporter.Errorf(
"Failed to create the operator role since the Installer role ARN '%v' does not have hosted CP policies",
args.installerRoleArn)
os.Exit(1)
}
}

operatorRolesList, err := convertV1OperatorIAMRoleIntoOcmOperatorIamRole(operatorIAMRoleList)
Expand Down