Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[WRKLDS-730] refactor route controller manager to use library-go server and ControlerCommand for generic setup" #25

Merged

Conversation

DennisPeriquet
Copy link
Contributor

Reverts #22

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This change is breaking ci 4.14 payloads:

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of (job/X or job/X, test/Y tuple) to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-aws-ovn

cc: @atiratree

…-go server and ControlerCommand for generic setup"
@openshift-ci openshift-ci bot requested review from bparees and soltysh May 24, 2023 19:47
@stbenjam
Copy link
Member

/label jira/valid-bug
/lgtm
/label approved
/skip

We are returning to a previously tested HEAD of the repo, as this is the most recent commit. Forcing this in.

@openshift-ci openshift-ci bot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2023
@DennisPeriquet
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-gcp

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@DennisPeriquet: Overrode contexts on behalf of DennisPeriquet: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-upgrade, ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-upgrade
/override ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DennisPeriquet, stbenjam
Once this PR has been reviewed and has the lgtm label, please assign coreydaley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit 38d9ec8 into openshift:main May 24, 2023
7 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@DennisPeriquet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants