[WRKLDS-730] refactor route controller manager to use library-go server and ControlerCommand for generic setup

[atiratree]

Revert of #25. The hypershift failures should be resolved by merging openshift/hypershift#2674 first. EDIT: seems we have a circular dependency openshift/hypershift#2674 (comment) and these 2 PRs need to be merged at the same time.

• simplify ControllerContext.

TODO:

• [WRKLDS-730] route-controller-manager deployment updates cluster-openshift-controller-manager-operator#295
• [WRKLDS-730] react to route-controller-manager refactoring hypershift#2674
• [WRKLDS-730] add dummy flags needed for a switch to library-go server and ControlerCommand #29
• WRKLDS-730: use default /healthz path for readiness probe in OCM and RCM hypershift#2873

[atiratree]

/hold

[atiratree]

/test e2e-gcp

[atiratree]

/retest

[atiratree]

/retest

[ingvagabund]

oc adm inspect returned an error. I wonder whether that's the reason why the CI job fails.

error: errors occurred while gathering data:
    [skipping gathering secrets/support due to error: secrets "support" not found, skipping gathering sharedconfigmaps.sharedresource.openshift.io due to error: the server doesn't have a resource type "sharedconfigmaps", skipping gathering sharedsecrets.sharedresource.openshift.io due to error: the server doesn't have a resource type "sharedsecrets"]

defined in https://github.com/openshift/api/tree/master/sharedresource.

Probably more like:

    journals.go:150: Error copying machine journals to artifacts directory: exit status 1
    fixture.go:492: Failed to dump machine journals; this is nonfatal: exit status 1

[ingvagabund]

/retest

[atiratree]

seems route-controller-manager is unable to become ready:

    create_cluster_test.go:293: condition Degraded status [True] doesn't match the expected status [False]
    create_cluster_test.go:304: Failed to validate HostedCluster conditions in 10m0s: timed out waiting for the condition

 - lastTransitionTime: "2023-08-02T11:52:43Z"
    message: openshift-route-controller-manager deployment has 1 unavailable replicas
    observedGeneration: 4
    reason: UnavailableReplicas
    status: "True"
    type: Degraded

  - lastProbeTime: null
    lastTransitionTime: "2023-08-02T11:52:54Z"
    message: 'containers with unready status: [route-controller-manager]'
    reason: ContainersNotReady
    status: "False"
    type: ContainersReady

 - containerID: cri-o://8f02b9f64dd545a0722b13cc4b91e2388fa50c4b26d8cc29c01194fb3b7b7023
    image: registry.build05.ci.openshift.org/ci-op-nljvl9tw/stable@sha256:67fe8c17f8e62f44ffba1215458f9a894f68f60d12b23c91a4ef06d6208131ce
    imageID: registry.build05.ci.openshift.org/ci-op-nljvl9tw/stable@sha256:67fe8c17f8e62f44ffba1215458f9a894f68f60d12b23c91a4ef06d6208131ce
    lastState: {}
    name: route-controller-manager
    ready: false
    restartCount: 0
    started: true
    state:
      running:
        startedAt: "2023-08-02T11:53:08Z"

not sure why, investigating...

[atiratree]

seems we need to update readiness paths in hypershift first: openshift/hypershift#2873

[atiratree]

/retest

[atiratree]

/retest

[atiratree]

/retest

[atiratree]

/retest

[atiratree]

tests passed
/hold cancel

[atiratree]

/assign @ingvagabund

[ingvagabund]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: atiratree, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.