New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ServiceAliasConfigKeys for dynamic config #108

Merged

openshift-merge-robot merged 1 commit into openshift:master from alexcern:fix/dynamic_router_ServiceAliasConfigKey

Jul 28, 2020

Contributor

alexcern commented Mar 25, 2020 •

edited

Following #51 doing it for other template methods.

Verified that the router is functional with these changes and ROUTER_HAPROXY_CONFIG_MANAGER='true'

Fixes #107


          Use ServiceAliasConfigKeys for dynamic config

ee41cde

Following openshift#51 doing it
for other template methods

openshift-ci-robot requested review from knobunc and smarterclayton

March 25, 2020 14:17

Contributor

openshift-ci-robot commented Mar 25, 2020

Hi @alexcern. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the needs-ok-to-test label

alexcern mentioned this pull request

Dynamic config manager not functional in 4.4 #107

Closed

Contributor

ironcladlou commented Mar 25, 2020

/approve
/ok-to-test

openshift-ci-robot added ok-to-test approved and removed needs-ok-to-test labels

Contributor Author

alexcern commented Mar 25, 2020

/retest

2 similar comments

Contributor Author

alexcern commented Mar 25, 2020

/retest

Contributor Author

alexcern commented May 5, 2020

/retest

Contributor

Miciah commented Jul 27, 2020

Nice, thanks!
/lgtm

openshift-ci-robot assigned Miciah

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Jul 27, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcern, ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/router/OWNERS~~ [Miciah,ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Jul 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Jul 27, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 9eca5f2 into openshift:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment