-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1813894: Stop using service ca from service account token #130
Conversation
@marun: This pull request references Bugzilla bug 1813894, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/lgtm |
I'll leave you to coordinate landing updates to the router and operator, but I'll leave this PR up as a placeholder until your PRs are proposed. |
@marun, I think you mean to |
I manually tested a cluster built with #130 and openshift/origin#24956 and did not have any test failures. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, mfojtik, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
And, for the record, openshift/cluster-ingress-operator#399 (merged) addresses #130 (comment). |
ci-operator failure:
/test unit |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@marun: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @sttts @mfojtik @deads2k