New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1835845: Report all backend metrics for when there are no endpoints #132
Bug 1835845: Report all backend metrics for when there are no endpoints #132
Conversation
Test failure is legitimate - before merging we'd disable that test.
…On Thu, May 14, 2020 at 8:03 PM OpenShift CI Robot ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton>: The following test
*failed*, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
ci/prow/e2e-aws 3104925
<3104925>
link
<https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_router/132/pull-ci-openshift-router-master-e2e-aws/441> /test
e2e-aws
Full PR test history
<https://prow.svc.ci.openshift.org/pr-history?org=openshift&repo=router&pr=132>.
Your PR dashboard
<https://prow.svc.ci.openshift.org/pr?query=is:pr+state:open+author:smarterclayton>.
Please help us cut down on flakes by linking to
<https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/openshift/router/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#132 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI37J6R6MJZDR2DJHY46A3RRSBDTANCNFSM4NBCSOHQ>
.
|
Nice! Thank you for taking care of this!!! |
/test e2e-aws |
Average of what? Latencies? haproxy doesn't track that. |
When no servers are exposed, backend metrics are needed to see how many requests are making it to a service. If we don't report them users can't see when no pods are up (a crashlooping service for instance would have no metrics at all because no pods are ready). Always report all backend metrics. Increases cardinality by O(routes), but prometheus is a lot faster now.
3104925
to
3b287c6
Compare
@smarterclayton: This pull request references Bugzilla bug 1835845, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@smarterclayton: This pull request references Bugzilla bug 1835845, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e2e-aws job failed due to: /test e2e-aws |
/retest now that the test has been updated |
/assign @Miciah |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smarterclayton: All pull requests linked via external trackers have merged: openshift/origin#24994, openshift/router#132. Bugzilla bug 1835845 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When no servers are exposed, backend metrics are needed to see how many requests are making it to a service. If we don't report them users can't see when no pods are up (a crashlooping service for instance would have no metrics at all because no pods are ready). Always report all backend
metrics. Increases cardinality by O(routes), but prometheus is a lot faster now and this should balance out.