Use generateCertKey consistently #138
Conversation
Fix some lookups in the service alias configuration's certificates map to use generateCertKey instead of using the host as the map key. * pkg/router/template/router.go (hasRequiredEdgeCerts): * pkg/router/template/template_helper.go (generateHAProxyCertConfigMap): Use generateCertKey to get the map key for the certificate in the service alias configuration.
openshift-ci-robot
added
the
approved
|
💯 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fix some lookups in the service alias configuration's certificates map to use
generateCertKeyinstead of using the host as the map key.pkg/router/template/router.go(hasRequiredEdgeCerts):pkg/router/template/template_helper.go(generateHAProxyCertConfigMap): UsegenerateCertKeyto get the map key for the certificate in the service alias configuration.