Bug 1889863: Fix logging of namespace label selector #204
Conversation
Fix the log output of any configured namespace label selectors on startup.
With NAMESPACE_LABELS set to "foo=bar", before this commit, the output
looked like this:
"msg"="router is only using routes in namespaces matching labels" "labels"=[{}]
After this commit, the output looks like this:
"msg"="router is only using routes in namespaces matching labels" "labels"="foo=bar"
Most likely the output was broken by the change from glog to logr/zap in
commit dc68ebf.
This commit fixes bug 1889863.
https://bugzilla.redhat.com/show_bug.cgi?id=1889863
* pkg/cmd/infra/router/router.go (NewFactory): Stringify label selectors
before logging them.
openshift-ci-robot
added
the
bugzilla/severity-low
|
@Miciah: This pull request references Bugzilla bug 1889863, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1889863 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix the log output of any configured namespace label selectors on startup.
With
NAMESPACE_LABELSset tofoo=bar, before this change, the output looked like this:After this change, the output looks like this:
Most likely the output was broken by the change from glog to logr/zap in dc68ebf.
pkg/cmd/infra/router/router.go(NewFactory): Stringify label selectors before logging them.