Address gosec G601 issues

[frobware]

$ gosec -version
Version: 2.5.0
Git tag: v2.5.0
Build date: 2020-10-26T11:52:22Z

On simple inspection the G601 issues from gosec looked innocuous
enough but I decided to clean these up anyway.

For the changes to router.go and template_helper.go I took the
simplest approach of creating a new variable (and copy). I could have
changed everything to be index based but I chose to go with the
smallest change.

PR inspired by #208

It still leaves open the question asked in #208 on whether we will run
this tool as during build and/or prior to a release.

[frobware]

Run multi-stage test e2e-agnostic - e2e-agnostic-gather-audit-logs container test expand_less | 1m1s
-- | --
[must-gather      ] OUT Get "https://api.ci-op-6tjfrnvr-4c798.origin-ci-int-gce.dev.openshift.com:6443/apis/image.openshift.io/v1/namespaces/openshift/imagestreams/must-gather": dial tcp 34.75.225.219:6443: i/o timeout [must-gather      ] OUT  [must-gather      ] OUT Using must-gather plug-in image: registry.redhat.io/openshift4/ose-must-gather:latest Unable to connect to the server: dial tcp 34.75.225.219:6443: i/o timeout error: failed to execute wrapped command: exit status 1

/retest

[sgreene570]

On simple inspection the G601 issues from gosec looked innocuous
enough but I decided to clean these up anyway.

Are there any other gosec codes we should be worried about?

[frobware]

Are there any other gosec codes we should be worried about?

Those were the immediate ones but there's a big list in #208 - some are more interesting than others (e.g., not handling errors from write(). I chose to do the memory aliasing as a discrete change.

[sgreene570]

Maybe we should consider setting something up like this

https://github.com/openshift/cluster-logging-operator/blob/master/golangci.yaml

[frobware]

Maybe we should consider setting something up like this

https://github.com/openshift/cluster-logging-operator/blob/master/golangci.yaml

Depends on how many false positives all of those throw up. Often there's too much noise. I used to run openshift/origin#25663 https://github.com/alecthomas/gometalinter in development to make sure that for at least the lines I touch I don't introduce anything new.

[frobware]

/retest

[frobware]

/retest

[sgreene570]

/retest

[sgreene570]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [frobware,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment