Allow configuring HTTP header name case adjustment #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
Miciah
force-pushed
the
allow-configuring-HTTP-header-name-case-adjustment
branch
2 times, most recently
from
e89d2cb
to
415abf3
Compare
sgreene570
reviewed
Nov 30, 2020
Implement the --http-header-name-case-adjustments flag and ROUTER_H1_CASE_ADJUST environment variable to allow specifying case adjustments for HTTP header names. * images/router/haproxy/conf/haproxy-config.template: Add "option h1-case-adjust-bogus-client" and "h1-case-adjust" settings to the global configuration if any adjustments are specified. Add "option h1-case-adjust-bogus-server" settings to routes that have the haproxy.router.openshift.io/h1-adjust-case annotation. * pkg/cmd/infra/router/template.go (TemplateRouter): Add HTTPHeaderNameCaseAdjustmentsString and HTTPHeaderNameCaseAdjustment fields. (Bind): Add --http-header-name-case-adjustments, which defaults to the value of the ROUTER_H1_CASE_ADJUST environment variable. (parseHTTPHeaderNameCaseAdjustments): New function. Parse a string value (such as provided with the newly added command-line flag) into a slice of HTTPHeaderNameCaseAdjustment values. (Complete): Use parseHTTPHeaderNameCaseAdjustments to parse HTTPHeaderNameCaseAdjustmentsString into HTTPHeaderNameCaseAdjustments. (Run): Specify HTTPHeaderNameCaseAdjustments in the plugin config. * pkg/router/template/plugin.go (TemplatePluginConfig): Add HTTPHeaderNameCaseAdjustments field. (NewTemplatePlugin): Specify HTTPHeaderNameCaseAdjustments in the internal template router config. * pkg/router/template/router.go (templateRouter, templateRouterCfg): Add httpHeaderNameCaseAdjustments field. (templateData): Add HTTPHeaderNameCaseAdjustments field. (newTemplateRouter): Specify httpHeaderNameCaseAdjustments in the template router. (writeConfig): Specify HTTPHeaderNameCaseAdjustments in the template parameters. * pkg/router/template/types.go (HTTPHeaderNameCaseAdjustments): New type. Specify an HTTP header name adjustment.
Miciah
force-pushed
the
allow-configuring-HTTP-header-name-case-adjustment
branch
from
415abf3
to
da09224
Compare
|
/retitle Allow configuring HTTP header name case adjustment |
openshift-ci-robot
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
2 tasks
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Uh oh: /test images |
|
/test e2e-agnostic |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
--http-header-name-case-adjustmentsflag andROUTER_H1_CASE_ADJUSTenvironment variable to allow specifying case adjustments for HTTP header names.images/router/haproxy/conf/haproxy-config.template: Addoption h1-case-adjust-bogus-clientandh1-case-adjustsettings to the global configuration if any adjustments are specified. Addoption h1-case-adjust-bogus-serversettings to routes that have thehaproxy.router.openshift.io/h1-adjust-caseannotation.pkg/cmd/infra/router/template.go(TemplateRouter): AddHTTPHeaderNameCaseAdjustmentsStringandHTTPHeaderNameCaseAdjustmentfields.(
Bind): Add--http-header-name-case-adjustments,which defaults to the value of theROUTER_H1_CASE_ADJUST environment variable.(
parseHTTPHeaderNameCaseAdjustments): New function. Parse a string value (such as provided with the newly added command-line flag) into a slice ofHTTPHeaderNameCaseAdjustmentvalues.(
Complete): UseparseHTTPHeaderNameCaseAdjustmentsto parseHTTPHeaderNameCaseAdjustmentsStringintoHTTPHeaderNameCaseAdjustments.(
Run): SpecifyHTTPHeaderNameCaseAdjustmentsin the plugin config.pkg/router/template/plugin.go(TemplatePluginConfig): AddHTTPHeaderNameCaseAdjustmentsfield.(
NewTemplatePlugin): SpecifyHTTPHeaderNameCaseAdjustmentsin the internal template router config.pkg/router/template/router.go(templateRouter,templateRouterCfg): AddhttpHeaderNameCaseAdjustmentsfield.(
templateData): AddHTTPHeaderNameCaseAdjustmentsfield.(
newTemplateRouter): SpecifyhttpHeaderNameCaseAdjustmentsin the template router.(
writeConfig): SpecifyHTTPHeaderNameCaseAdjustmentsin the template parameters.pkg/router/template/types.go(HTTPHeaderNameCaseAdjustments): New type. Specify an HTTP header name adjustment.