Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1963243: Add a condition to check if the Endpoints ID is duplicated #288

Merged
merged 1 commit into from May 27, 2021
Merged

[release-4.7] Bug 1963243: Add a condition to check if the Endpoints ID is duplicated #288

merged 1 commit into from May 27, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #285

/assign sgreene570

@bysnupy
Add a condition to check if the Endpoints ID is duplicated
8e5e70b 
EndpointSlice can be duplicated. For suppressing broken the haproxy.config, add a condition to check if the Endpoints is duplicated before adding the new endpoints actually.
Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1961550
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 21, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@openshift-cherrypick-robot: Bugzilla bug 1961550 has been cloned as Bugzilla bug 1963243. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1963243: Add a condition to check if the Endpoints ID is duplicated

In response to this:

[release-4.7] Bug 1961550: Add a condition to check if the Endpoints ID is duplicated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1961550: Add a condition to check if the Endpoints ID is duplicated [release-4.7] Bug 1963243: Add a condition to check if the Endpoints ID is duplicated May 21, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1963243, which is invalid:

  • expected dependent Bugzilla bug 1961550 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1963243: Add a condition to check if the Endpoints ID is duplicated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link

/bugzilla refresh
/retest

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2021

@sgreene570: This pull request references Bugzilla bug 1963243, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1961550 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1961550 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @quarterpin

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from quarterpin May 24, 2021 13:40
@sgreene570
Copy link

/cc @bysnupy
/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link
Author

@sgreene570: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cc @bysnupy
/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from bysnupy May 24, 2021 13:41
@Miciah
Copy link
Contributor

Miciah commented May 24, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2021
@sgreene570
Copy link

/retest

candita
candita reviewed May 24, 2021
View reviewed changes
pkg/router/template/plugin.go
out = append(out, ep)
duplicated[ep.ID] = true
} else {
log.V(4).Info("skip a duplicated endpoints to add", ep.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the message doesn't make sense. Maybe "skipped adding a duplicated endpoints object"
/lgtm

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #285, @frobware and I noticed this but decided it wasn't worth lamenting over.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@quarterpin
Copy link

/bugzilla cc-qa

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

@quarterpin: This pull request references Bugzilla bug 1963243, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1961550 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1961550 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @quarterpin

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@quarterpin
Copy link

/lgtm
/label qe-approved

Verified via pre-merge verification workflow, more reference related to the test can be found in:
https://bugzilla.redhat.com/show_bug.cgi?id=1963243#c1

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, Miciah, openshift-cherrypick-robot, quarterpin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bysnupy
Copy link
Member

bysnupy commented May 25, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 8e5e70b link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sgreene570
Copy link

/skip

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0490856 into openshift:release-4.7 May 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1963243 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1963243: Add a condition to check if the Endpoints ID is duplicated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 27, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

@sgreene570: new pull request created: #292

In response to this:

/cc @bysnupy
/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita candita left review comments

@sgreene570 sgreene570 sgreene570 left review comments

@danehans danehans Awaiting requested review from danehans

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@quarterpin quarterpin Awaiting requested review from quarterpin

@bysnupy bysnupy Awaiting requested review from bysnupy

Assignees

@Miciah Miciah

@candita candita

@sgreene570 sgreene570

@quarterpin quarterpin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @sgreene570 @Miciah @openshift-bot @quarterpin @bysnupy @candita @sdodson @openshift-merge-robot