Hack: Add initial hacking instructions #299
Conversation
openshift-ci
bot
added
the
approved
sgreene570
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
sgreene570
force-pushed
the
debug
branch
2 times, most recently
from
9050f46
to
529453b
Compare
This commit adds 2 new "hacking" files, `hack/Dockerfile.debug` and `hack/Makefile.debug`, as well as a new `HACKING.md` readme file. Note that the files and instructions provided in this commit are intended for Router development and are not officially supported or guaranteed to work.
|
/cc @frobware @alebedev87 |
|
As this is what I already do... /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sgreene570
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
We can wait til master opens for 4.9 to merge this. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/hold for CI sake |
openshift-ci
bot
added
the
do-not-merge/hold
|
If you are interested I added a version inspired from Andy's one which has an option to use local CRC and podman as build/push tool: Makefile.debug. Just ignore my comment if this setup is not used by other members of NetEdge team. |
Interesting! I haven't used CRC in a long time, but maybe I should change that. I'd be curious to see this router dev setup through a demo of sorts, at the very least. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This commit adds 2 new "hacking" files,
hack/Dockerfile.debugand
hack/Makefile.debug, as well as a newHACKING.mdreadme file.Note that the files and instructions provided in this commit are
intended for Router development and are not officially supported
or guaranteed to work.