Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2010227: HTTPS redirect happens even if there is a more specific http-only route #367

Merged
merged 1 commit into from Jun 23, 2022
Merged

[release-4.9] Bug 2010227: HTTPS redirect happens even if there is a more specific http-only route #367

merged 1 commit into from Jun 23, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #343

/assign miheer

@miheer
Bug 2002205 - HTTPS redirect happens even if there is a more specific…
c014a00 
… http-only route

Let's say we have 2 routes like this:
- HTTP-only route for "myapp.apps.example.com" domain and "/mypath" path
- HTTPS-edge-redirect route for "myapp.apps.example.com" and no path

In such situation, redirect is sent for any query to "myapp.apps.example.com", including "myapp.apps.example.com/mypath", so the more specific path route is not taking precedence as expected.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1896474 with correct target release. Retitling PR to link to clone:
/retitle [release-4.9] Bug 2010227: HTTPS redirect happens even if there is a more specific http-only route

In response to this:

[release-4.9] Bug 1896474: HTTPS redirect happens even if there is a more specific http-only route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 1896474: HTTPS redirect happens even if there is a more specific http-only route [release-4.9] Bug 2010227: HTTPS redirect happens even if there is a more specific http-only route Jan 10, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2010227, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1896474 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1896474 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

[release-4.9] Bug 2010227: HTTPS redirect happens even if there is a more specific http-only route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 10, 2022
@melvinjoseph86
Copy link

/bugzilla cc-qa

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@melvinjoseph86: This pull request references Bugzilla bug 2010227, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1896474 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1896474 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@melvinjoseph86
Copy link

/lgtm
/label qe-approved

Verified via pre-merge verification workflow, more references related to the test can be found in:
https://bugzilla.redhat.com/show_bug.cgi?id=2010227#c8

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 11, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2022
@melvinjoseph86
Copy link

/retest

@frobware
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, melvinjoseph86, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2022
@melvinjoseph86
Copy link

/cherry-pick-approved

@lihongan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 28, 2022
@Miciah
Copy link
Contributor

Miciah commented Jun 3, 2022

This change should be safe now that fe7ea46 has merged, but the BZ still needs doc text.

@Miciah
Copy link
Contributor

Miciah commented Jun 23, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 23, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD fe7ea46 and 8 for PR HEAD c014a00 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit f89bbce into openshift:release-4.9 Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2010227 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2010227: HTTPS redirect happens even if there is a more specific http-only route

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melvinjoseph86 melvinjoseph86 Awaiting requested review from melvinjoseph86

@Miciah Miciah Awaiting requested review from Miciah

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@frobware frobware

@miheer miheer

@lihongan lihongan

@quarterpin quarterpin

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @melvinjoseph86 @frobware @lihongan @Miciah @openshift-ci-robot @miheer @quarterpin @ShudiLi