Bug 1780398: status: performIngressConditionUpdate: Retry on 403 #68
Conversation
If a status update fails with a forbidden error, retry the update. Keep retrying failed updates as long as the route has the wrong status. This commit fixes bug 1780398. https://bugzilla.redhat.com/show_bug.cgi?id=1780398 * pkg/router/controller/status.go (performIngressConditionUpdate): Retry on forbidden errors. Never give up retrying after an error.
openshift-ci-robot
added
size/XS
|
Makes sense, thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Miciah
changed the title
|
@Miciah: This pull request references Bugzilla bug 1780398, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@Miciah: This pull request references Bugzilla bug 1780398, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: All pull requests linked via external trackers have merged. Bugzilla bug 1780398 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 |
|
@Miciah: new pull request created: #70 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If a status update fails with a forbidden error, retry the update.
Keep retrying failed updates as long as the route has the wrong status.
pkg/router/controller/status.go(performIngressConditionUpdate): Retry on forbidden errors. Never give up retrying after an error.