[release-4.3] Bug 1809668: Start graceful shutdown on SIGTERM #98

openshift-cherrypick-robot · 2020-03-04T16:19:27Z

This is an automated cherry-pick of #94

/assign smarterclayton

When the main process recieves SIGTERM or SIGINT, wait ROUTER_GRACEFUL_SHUTDOWN_DELAY (default: 45) seconds and then signal the reload script with ROUTER_SHUTDOWN=true that a graceful termination is requested. The reload-haproxy script then invokes USR1 on the child processes and waits ROUTER_MAX_SHUTDOWN_TIMEOUT or MAX_RELOAD_WAIT_TIME (default 30) seconds before invoking TERM on the child processes. If TERM is invoked the script exits with 1, indicating that not all processes completed their work. Clients with long running requests should set ROUTER_MAX_SHUTDOWN_TIMEOUT as appropriate to ensure all connections exit cleanly.

openshift-ci-robot · 2020-03-04T16:19:32Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1809665, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
expected Bugzilla bug 1809665 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-09T15:11:43Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ironcladlou · 2020-03-09T15:15:50Z

/approve
/lgtm

openshift-ci-robot · 2020-03-09T15:17:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~images/router/OWNERS~~ [ironcladlou]
~~pkg/cmd/infra/router/OWNERS~~ [ironcladlou]
~~pkg/router/OWNERS~~ [ironcladlou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-03-09T15:49:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-09T16:03:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-30T01:01:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-30T01:01:28Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-31T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-31T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-01T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-01T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-03T01:01:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-03T01:01:48Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-04T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-04T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-05T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-05T01:01:22Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-06T01:00:31Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-06T01:00:35Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-07T01:00:39Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-07T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-08T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-08T01:01:23Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-09T01:00:37Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-09T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-10T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-10T01:01:22Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-11T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-11T01:00:49Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-12T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-12T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-13T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-13T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-14T01:00:28Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-14T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-15T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-15T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-16T01:00:28Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-16T01:00:41Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-17T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-17T01:01:23Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-10-20T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-10-20T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1809668, which is invalid:

expected dependent Bugzilla bug 1809667 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-10-30T19:27:21Z

Now that 4.3 is EOL please consider closing this and the associated bug unless there's a customer that was promised this fix.

sdodson · 2020-11-05T18:23:41Z

/close
CLOSED DEFERRED, 4.3 is EOL

openshift-ci-robot · 2020-11-05T18:23:59Z

@sdodson: Closed this PR.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Mar 4, 2020

Bug 1809665: Start graceful shutdown on SIGTERM #94

Merged

openshift-ci-robot assigned smarterclayton Mar 4, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 4, 2020

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2020

openshift-ci-robot requested review from ironcladlou and pweil- March 4, 2020 16:20

smarterclayton changed the title ~~[release-4.3] Bug 1809665: Start graceful shutdown on SIGTERM~~ [release-4.3] Bug 1809668: Start graceful shutdown on SIGTERM Mar 9, 2020

openshift-ci-robot assigned ironcladlou Mar 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2020

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 30, 2020

openshift-ci-robot closed this Nov 5, 2020

[release-4.3] Bug 1809668: Start graceful shutdown on SIGTERM #98

[release-4.3] Bug 1809668: Start graceful shutdown on SIGTERM #98

Conversation

openshift-cherrypick-robot commented Mar 4, 2020

openshift-ci-robot commented Mar 4, 2020

openshift-ci-robot commented Mar 9, 2020

ironcladlou commented Mar 9, 2020

openshift-ci-robot commented Mar 9, 2020

openshift-bot commented Mar 9, 2020

openshift-bot commented Mar 9, 2020

openshift-bot commented May 30, 2020

openshift-ci-robot commented May 30, 2020

openshift-bot commented May 31, 2020

openshift-ci-robot commented May 31, 2020

openshift-bot commented Jun 1, 2020

openshift-ci-robot commented Jun 1, 2020

openshift-bot commented Jun 3, 2020

openshift-ci-robot commented Jun 3, 2020

openshift-bot commented Jun 4, 2020

openshift-ci-robot commented Jun 4, 2020

openshift-bot commented Jun 5, 2020

openshift-ci-robot commented Jun 5, 2020

openshift-bot commented Oct 6, 2020

openshift-ci-robot commented Oct 6, 2020

openshift-bot commented Oct 7, 2020

openshift-ci-robot commented Oct 7, 2020

openshift-bot commented Oct 8, 2020

openshift-ci-robot commented Oct 8, 2020

openshift-bot commented Oct 9, 2020

openshift-ci-robot commented Oct 9, 2020

openshift-bot commented Oct 10, 2020

openshift-ci-robot commented Oct 10, 2020

openshift-bot commented Oct 11, 2020

openshift-ci-robot commented Oct 11, 2020

openshift-bot commented Oct 12, 2020

openshift-ci-robot commented Oct 12, 2020

openshift-bot commented Oct 13, 2020

openshift-ci-robot commented Oct 13, 2020

openshift-bot commented Oct 14, 2020

openshift-ci-robot commented Oct 14, 2020

openshift-bot commented Oct 15, 2020

openshift-ci-robot commented Oct 15, 2020

openshift-bot commented Oct 16, 2020

openshift-ci-robot commented Oct 16, 2020

openshift-bot commented Oct 17, 2020

openshift-ci-robot commented Oct 17, 2020

openshift-bot commented Oct 20, 2020

openshift-ci-robot commented Oct 20, 2020

sdodson commented Oct 30, 2020

sdodson commented Nov 5, 2020

openshift-ci-robot commented Nov 5, 2020