Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie SCC lifecycle with KataConfig #193

Merged
merged 4 commits into from Jun 1, 2022
Merged

Conversation

bpradipt
Copy link
Contributor

@bpradipt bpradipt commented May 25, 2022

Fixes: KATA-1569

- Description of the problem which is fixed/What is the use case
The custom SCC created by the operator doesn't get deleted on the removal of KataConfig
@gkurz attempted to fix the issue in the following PR #191.
However, triggered by the suggestion from @littlejawa, we felt its logical to align the SCC lifecycle with the KataConfig lifecycle in further discussions. There is no reason to keep the SCC handling separated since kata-monitor pods use the custom SCC, and kata-monitor pods get created only after KataConfig creation. Thanks to @littlejawa and @gkurz for forcing us to relook at the issue which resulted in this PR. With this PR, the SCC gets created on KataConfig creation and cleaned up on deletion of the KataConfig.

- What I did
Changed how SCC gets created and deleted

- How to verify it

Check whether the customer SCC gets deleted after KataConfig deletion

- Description for the changelog

Tie SCC lifecycle with KataConfig

@bpradipt bpradipt requested a review from pmores May 25, 2022 11:06
@openshift-ci openshift-ci bot requested a review from jensfr May 25, 2022 11:06
@bpradipt
Copy link
Contributor Author

/assign @gkurz

@openshift-ci
Copy link

openshift-ci bot commented May 25, 2022

@bpradipt: GitHub didn't allow me to assign the following users: gkurz.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gkurz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bpradipt bpradipt mentioned this pull request May 25, 2022
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2022
@gkurz
Copy link
Member

gkurz commented May 31, 2022

I'm skipping the test case commit as I don't really have the knowledge to review. Rest looks good.

@bpradipt
Copy link
Contributor Author

bpradipt commented Jun 1, 2022

/retest

Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bpradipt !

@gkurz
Copy link
Member

gkurz commented Jun 1, 2022

@bpradipt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/4.9-sandboxed-containers-operator-e2e 7ef52bc link false /test 4.9-sandboxed-containers-operator-e2e
ci/prow/sandboxed-containers-operator-e2e 7ef52bc link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

The tests seems to be failing because of infra problems, not related to the changes in this PR.

@bpradipt
Copy link
Contributor Author

bpradipt commented Jun 1, 2022

/retest

4 similar comments
@bpradipt
Copy link
Contributor Author

bpradipt commented Jun 1, 2022

/retest

@bpradipt
Copy link
Contributor Author

bpradipt commented Jun 1, 2022

/retest

@bpradipt
Copy link
Contributor Author

bpradipt commented Jun 1, 2022

/retest

@gkurz
Copy link
Member

gkurz commented Jun 1, 2022

/retest

@bpradipt
Copy link
Contributor Author

bpradipt commented Jun 1, 2022

last try
/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2022

@bpradipt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 7ef52bc link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bpradipt bpradipt merged commit 8370d42 into openshift:master Jun 1, 2022
@bpradipt bpradipt deleted the scc-delete branch June 8, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants