Remove scc on uninstall #191
Conversation
Some code in main() can fail but there's no rollback path. It isn't possible to use `defer` because error paths call os.Exit(), which means that main() doesn't return. Move all the code to a _regular_ function that returns its status instead of calling os.Exit(). This will to implement proper rollback using `defer`. Signed-off-by: Greg Kurz <groug@kaod.org>
The controller creates the SCC but never deletes it. This causes the SCC to remain alive in the cluster even if the rest of the installation fails, e.g. failure to create the webhook, or if the operator is uninstalled. Introduce proper rollback with a defered function call. Signed-off-by: Greg Kurz <groug@kaod.org>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @gkurz. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -152,6 +153,13 @@ func createScc(ctx context.Context, mgr manager.Manager) error { | |||
| return err | |||
| } | |||
|
|
|||
| func deleteScc(ctx context.Context, mgr manager.Manager) error { | |||
There was a problem hiding this comment.
Notice that this function returns an error that is ignored.
| @@ -146,6 +153,13 @@ func createScc(ctx context.Context, mgr manager.Manager) error { | |||
| return err | |||
| } | |||
|
|
|||
| func deleteScc(ctx context.Context, mgr manager.Manager) error { | |||
|
|
|||
There was a problem hiding this comment.
I think we should check for the presence of existing KataConfig and proceed with delete when no KataConfig exist.
Let's make sure that the controller removes the SCC it has created when it exits.
This ensures that the SCC doesn't stay around when OSC is uninstalled or when
installation fails.
Fixes: https://issues.redhat.com/browse/KATA-156