Include a direct dependency to controller-tools #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller-tools is required for manifest generation and for downstream builds we need to cache all the modules. Consequently all the required modules should be in go.mod Fixes: openshift#294 Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
Merged
|
@bpradipt: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
pmores
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
controller-tools is required for manifest generation and for downstream builds we need to cache all the modules. Consequently all the required modules should be in go.mod
- What I did
Called the Version() method from controller-tools
- How to verify it
Running
go mod tidyshouldn't remove the controller-tools- Description for the changelog
Add explicit dependency to controller-tools