Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Include a direct dependency to controller-tools" #301

Merged
merged 1 commit into from Apr 27, 2023
Merged

Revert "Include a direct dependency to controller-tools" #301

merged 1 commit into from Apr 27, 2023

Conversation

gkurz
Copy link
Member

@gkurz gkurz commented Apr 27, 2023

Reverts #295 with same justification as #297 :

Reverting controller-tools implicit addition as there are more deps that are required to be directly included for successful downstream builds

pmores
pmores approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@pmores pmores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of sad to see this go but lgtm. ;-)

@openshift-ci openshift-ci bot requested review from bpradipt and pmores April 27, 2023 15:26
@gkurz gkurz merged commit 59306f4 into main Apr 27, 2023
3 of 4 checks passed
@gkurz gkurz deleted the revert-295-fix-294 branch November 28, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littlejawa littlejawa littlejawa approved these changes

@bpradipt bpradipt Awaiting requested review from bpradipt

@pmores pmores Awaiting requested review from pmores

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkurz @littlejawa @pmores