Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerpod-ctrl: bump to fix dangling VMs #360

Merged
merged 1 commit into from Nov 21, 2023
Merged

peerpod-ctrl: bump to fix dangling VMs #360

merged 1 commit into from Nov 21, 2023

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Nov 15, 2023

Build:

quay.io/snir/osc-operator:9.9.2519
quay.io/snir/osc-operator-bundle:v9.9.2519
quay.io/snir/osc-operator-catalog:v9.9.2519

@snir911 snir911 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@snir911 snir911 self-assigned this Nov 15, 2023
@snir911 snir911 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2023
bpradipt
bpradipt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @snir911

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@snir911
Copy link
Contributor Author

snir911 commented Nov 20, 2023

putting on hold, let's wait for pre-merge testing, cc @tbuskey

@snir911 snir911 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
gkurz
gkurz approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @snir911 !

Just a small nit : the e9406d21bc7dbe303e733f2c80d860ed52a5e944 SHA1 mentioned in the commit message belongs to CAA. IMHO it would be better to provide the full URL confidential-containers/cloud-api-adaptor@e9406d2 instead.

@snir911
peerpod-ctrl: bump to fix dangling VMs
6aedf96 
fixed in confidential-containers/cloud-api-adaptor@e9406d2

executed:
go get github.com/confidential-containers/cloud-api-adaptor/peerpod-ctrl@4bb0a8dfe3494c0c417914d1b56b7e75b4f31516 \
&& go mod tidy

Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@gkurz
Copy link
Member

gkurz commented Nov 20, 2023

/lgtm
Thanks for the fix in the commit log @snir911 !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023
@gkurz
Copy link
Member

gkurz commented Nov 20, 2023

Waiting for pre-merge status from @tbuskey.

@tbuskey
Copy link
Contributor

tbuskey commented Nov 20, 2023 •
edited

Failing to install kataconfig on 2 clusters
Logs in https://issues.redhat.com/browse/KATA-2519

littlejawa
littlejawa approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @snir911

@gkurz
Copy link
Member

gkurz commented Nov 21, 2023

Failing to install kataconfig on 2 clusters Logs in https://issues.redhat.com/browse/KATA-2519

Node is degraded because of :

                      - name: SANDBOXED_CONTAINERS_EXTENSION
                        value: kata-containers

@snir911 can you please re-push another build with this set to sandboxed-containers ?

@gkurz
Copy link
Member

gkurz commented Nov 21, 2023

Failing to install kataconfig on 2 clusters Logs in https://issues.redhat.com/browse/KATA-2519

Node is degraded because of :

                      - name: SANDBOXED_CONTAINERS_EXTENSION
                        value: kata-containers

@snir911 can you please re-push another build with this set to sandboxed-containers ?

Workaround suggested by @snir911 in the jira ticket :

oc set env deployment.apps/controller-manager SANDBOXED_CONTAINERS_EXTENSION=sandboxed-containers -n openshift-sandboxed-containers-operator

@tbuskey
Copy link
Contributor

tbuskey commented Nov 21, 2023

premerge pass
/lgtm

@gkurz gkurz merged commit d271b9f into openshift:devel Nov 21, 2023
@gkurz gkurz mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littlejawa littlejawa littlejawa approved these changes

@gkurz gkurz gkurz approved these changes

@bpradipt bpradipt bpradipt approved these changes

@pmores pmores Awaiting requested review from pmores

Assignees

@gkurz gkurz

@tbuskey tbuskey

@bpradipt bpradipt

@snir911 snir911

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@snir911 @gkurz @tbuskey @littlejawa @bpradipt