Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to main for 1.5 #363

Merged
merged 8 commits into from Nov 23, 2023
Merged

Merge to main for 1.5 #363

merged 8 commits into from Nov 23, 2023

Conversation

gkurz
Copy link
Member

@gkurz gkurz commented Nov 23, 2023

- Description of the problem which is fixed/What is the use case

This brings fixes for :

- What I did

- How to verify it

- Description for the changelog

#360
#361
#362

snir911 and others added 8 commits November 20, 2023 14:58
fixed in confidential-containers/cloud-api-adaptor@e9406d2

executed:
go get github.com/confidential-containers/cloud-api-adaptor/peerpod-ctrl@4bb0a8dfe3494c0c417914d1b56b7e75b4f31516 \
&& go mod tidy

Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
peerpod-ctrl: bump to fix dangling VMs
This will also allow convenient using of IMAGE_TAG_BASE for custom builds

Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
makefile: match operator, bundle and catalog versioning
this allows installtion completion without being blocked waiting
for image creation when image creation isn't implemented for
cloud-provider

Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
image-generator: skip image creation for unsupported providers
Copy link
Contributor

@littlejawa littlejawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@gkurz
Copy link
Member Author

gkurz commented Nov 23, 2023

/override ci/prow/check

Copy link

openshift-ci bot commented Nov 23, 2023

@gkurz: Overrode contexts on behalf of gkurz: ci/prow/check

In response to this:

/override ci/prow/check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@snir911
Copy link
Contributor

snir911 commented Nov 23, 2023

Thanks @gkurz ! LGTM

@littlejawa
Copy link
Contributor

/test ci-index-openshift-sandboxed-containers-operator-bundle

@jensfr
Copy link
Contributor

jensfr commented Nov 23, 2023

/retest

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

Copy link

openshift-ci bot commented Nov 23, 2023

@gkurz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sandboxed-containers-operator-e2e 9e60bd2 link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gkurz gkurz merged commit 9891e9b into openshift:main Nov 23, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants