makefile: match operator, bundle and catalog versioning #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpradipt
reviewed
Nov 20, 2023
bpradipt
reviewed
Nov 20, 2023
gkurz
reviewed
Nov 21, 2023
There was a problem hiding this comment.
This will also allow convenient using of IMG_TAG_BUILD for custom builds
This variable doesn't exist in the tree. Assuming you are actually referring to IMAGE_TAG_BASE, I'm not sure to see how this change makes things more convenient. Could you elaborate @snir911 ?
gkurz
approved these changes
Nov 21, 2023
This will also allow convenient using of IMAGE_TAG_BASE for custom builds Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
|
/lgtm |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me the right approach, cc @gkurz @pmores @bpradipt for confirmation this is legit