image-generator: skip image creation for unsupported providers #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snir911
added
the
do-not-merge/hold
gkurz
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Thanks @snir911 ! The change seems to be good but I still have some comments :
- please add some context in the commit log : motivation, link to jira...
- this moves
setupCloudProvider()intonewImageGenerator(): not sure to understand why and this makes the change harder to review. Could the refactoring happen in a preliminary commit ?
snir911
removed
the
do-not-merge/hold
this allows installtion completion without being blocked waiting for image creation when image creation isn't implemented for cloud-provider Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
gkurz
approved these changes
Nov 22, 2023
|
Now waiting for @tbuskey to pre-merge test this PR for regressions with supported providers. |
|
@tbuskey , no, it fetches the cloud-provider name from the the infrastructure object of the cluster |
|
Azure works |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows installtion completion without being blocked waiting
for image creation when image creation isn't implemented for
cloud-provider